Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-77598

Complete plugin uninstallation from MDL-52805 & MDL-77308

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • 4.2
    • 4.2
    • Administration
    • MOODLE_402_STABLE
    • MOODLE_402_STABLE
    • Hide
      Setup before patch
      1. Install 4.2 site using March 3rd weekly release (one which includes the original plugins subsequently removed) 

        git checkout 556208417de
        		 
        mdk install

      After patch
      1. Checkout the master branch which contains the patch for this issue.
      2. Complete upgrade
      3. Confirm the following query returns no rows: 

        SELECT *
        		 
        FROM mdl_config_plugins
        		 
        WHERE plugin = 'logstore_legacy'
        		 
        OR plugin LIKE 'tinymce\_%'

      Bumping version again
      1. Increase the $version number in version.php. (e.g. by .01 or by 1)
      2. Try to upgrade the site
      3. Confirm that there are no more plugins to be deleted related to the legacy log store and TinyMCE
      Show
      Setup before patch Install 4.2 site using March 3rd weekly release (one which includes the original plugins subsequently removed) git checkout 556208417de mdk install After patch Checkout the master branch which contains the patch for this issue. Complete upgrade Confirm the following query returns no rows: SELECT * FROM mdl_config_plugins WHERE plugin = 'logstore_legacy' OR plugin LIKE 'tinymce\_%' Bumping version again Increase the $version number in version.php. (e.g. by .01 or by 1) Try to upgrade the site Confirm that there are no more plugins to be deleted related to the legacy log store and TinyMCE

      MDL-52805 removed the legacy log store, but didn't complete with appropriate upgrade step to flush the config
      MDL-77308 removed tinymce, but looks like it ought to also remove it's sub-plugins too

      Same issue as described previously at MDL-72675 - you are prompted to remove those plugins on each version bump (but it never appears to succeed), so are prompted again at the next version bump (ad infinitum)

        1. afterpatch.gif
          afterpatch.gif
          89 kB
        2. bump version.gif
          bump version.gif
          713 kB
        3. Screenshot from 2023-03-10 16-09-32.png
          Screenshot from 2023-03-10 16-09-32.png
          80 kB

            pholden Paul Holden
            pholden Paul Holden
            Carlos Castillo Carlos Castillo
            Jun Pataleta Jun Pataleta
            Ron Carl Alfon Yu Ron Carl Alfon Yu
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 2 hours, 19 minutes
                2h 19m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.