-
Bug
-
Resolution: Fixed
-
Minor
-
4.0.6, 4.1.1, 4.2
-
MOODLE_400_STABLE, MOODLE_401_STABLE, MOODLE_402_STABLE
-
MOODLE_403_STABLE
-
Curiously, @const is not a valid PHPDoc tag.
Link: https://docs.phpdoc.org/3.0/guide/references/phpdoc/tags/var.html
Some more sources about to using @var instead:
- (PHP-FIG - draft) https://github.com/php-fig/fig-standards/blob/master/proposed/phpdoc-tags.md#518-var
- ...
So all current uses of @const in core (our code) should be moved to @var [type] description instead.
There are a few uses to fix:
$ ag '@const' --php | wc -l
|
37
|
So this issue is about to:
- Fix all current @const uses in core (excluding 3rd part libs).
- PR#110 - Ensure that local_moodlechecker detects wrong uses.
- PR#673 - Amend the coding style, so it matches the FIG/PHPDoc.
Ciao
- Discovered while testing
-
MDL-76459 Expand Database Identifier Sizes (Column names, Table names)
- Closed