[MDL-77608] Add namespace to H5P activity lib.php testcase - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 4.1.2
Fix Version/s: 4.0.8, 4.1.3
Component/s: H5P, Unit tests
Labels:
- ci
- triaged

Affected Branches:
MOODLE_401_STABLE
Fixed Branches:
MOODLE_400_STABLE, MOODLE_401_STABLE
Pull from Repository:
https://github.com/paulholden/moodle.git
Pull 4.0 Branch:
~~MDL-77608~~-400
Pull 4.0 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_400_STABLE...paulholden:MDL-77608-400
Pull 4.1 Branch:
~~MDL-77608~~-401
Pull 4.1 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_401_STABLE...paulholden:MDL-77608-401
Pull Master Branch:
~~MDL-77608~~
Pull Master Diff URL:
https://github.com/moodle/moodle/compare/master...paulholden:MDL-77608
Testing Instructions:
Hide

Run the following, confirm there are no files listed:

$ git grep -l "^class lib_test" | xargs grep --files-without-match '^namespace'

Confirm the following tests pass:

$ vendor/bin/phpunit mod/h5pactivity/tests/lib_test.php
Show
Run the following, confirm there are no files listed: $ git grep -l "^class lib_test" | xargs grep --files-without-match '^namespace' Confirm the following tests pass: $ vendor/bin/phpunit mod/h5pactivity/tests/lib_test.php

Description

All tests should ideally be in the namespace of the component/class they are testing - especially in the case of generic lib_test classes (of which there are a few across different components)

Somehow this test escaped similar changes in ~~MDL-73352~~

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

(I) Passed -- (400)MDL-77608.png
88 kB
17/Mar/23 10:50 AM
(I) Passed -- (401)MDL-77608.png
90 kB
17/Mar/23 10:50 AM
(I) Passed -- (Master)MDL-77608.png
112 kB
17/Mar/23 10:50 AM

Issue Links

has a non-specific relationship to

MDL-73352 Fix namespace and class names for lib / locallib cases

Closed

MDL-68394 Integrate mod_h5pactivity with recent activity plugins

Closed

Activity

People

Assignee:: Paul Holden

Reporter:: Paul Holden

Peer reviewer:: Eloy Lafuente (stronk7)

Integrator:: Jun Pataleta

Tester:: Kim Jared Lucas

Participants:: CiBoT, Eloy Lafuente (stronk7), Jun Pataleta, Kim Jared Lucas, Paul Holden

Component watchers:: Amaia Anabitarte, Carlos Escobedo, Laurent David, Mikel Martín Corrales, Sabina Abellan, Sara Arjona (@sarjona)

Votes:: 1 Vote for this issue

Watchers:: 4 Start watching this issue

Dates

Created:: 13/Mar/23 5:34 PM

Updated:: 18/Mar/23 1:52 AM

Resolved:: 18/Mar/23 1:52 AM

Fix Release Date:: 24/Apr/23

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

1h 2m