[MDL-77618] Browsers auto-completing the user's password into admin setting password unmask fields - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 4.1.2
Fix Version/s: 4.0.8, 4.1.3
Component/s: Administration
Labels:

Affected Branches:
MOODLE_401_STABLE
Fixed Branches:
MOODLE_400_STABLE, MOODLE_401_STABLE
Pull from Repository:
https://github.com/brendanheywood/moodle
Pull 4.0 Branch:
~~MDL-77618~~-admin-password-autocomplete-MOODLE_400_STABLE
Pull 4.0 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_400_STABLE...brendanheywood:MDL-77618-admin-password-autocomplete-MOODLE_400_STABLE
Pull 4.1 Branch:
~~MDL-77618~~-admin-password-autocomplete-MOODLE_401_STABLE
Pull 4.1 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_401_STABLE...brendanheywood:MDL-77618-admin-password-autocomplete-MOODLE_401_STABLE
Pull Master Branch:
~~MDL-77618~~-admin-password-autocomplete
Pull Master Diff URL:
https://github.com/moodle/moodle/compare/master...brendanheywood:moodle:MDL-77618-admin-password-autocomplete
Testing Instructions:
Hide

Ideally, reproduce the bug in master first.

Test it in different browsers (Edge eg Version 111.0.1661.41 (Official build) (64-bit), Chrome, Firefox, Safari...)

Saved user password in the browser password manager

Selected Autofill password

Navigated to /admin/search.php?query=cronremotepassword

Unmasked cronremotepassword

Confirm the password is not autofilled from the browser password manager

Install https://github.com/catalyst/moodle-auth_saml2 :

git clone https://github.com/catalyst/moodle-auth_saml2.git auth/saml2

In the "New settings - SAML2" page, confirm the auth_saml2 | privatekeypass is not auto-filled from the browser password manager (the default value should be something like [hash][server] (i.e. KMz0ExQJf5CBZ8aw9W2sxgWWPOAtrXY2localhost).
Show
Ideally, reproduce the bug in master first. Test it in different browsers (Edge eg Version 111.0.1661.41 (Official build) (64-bit), Chrome, Firefox, Safari...) Saved user password in the browser password manager Selected Autofill password Navigated to /admin/search.php?query=cronremotepassword Unmasked cronremotepassword Confirm the password is not autofilled from the browser password manager Install https://github.com/catalyst/moodle-auth_saml2 : git clone https: //github.com/catalyst/moodle-auth_saml2.git auth/saml2 In the "New settings - SAML2" page, confirm the auth_saml2 | privatekeypass is not auto-filled from the browser password manager (the default value should be something like [hash] [server] (i.e. KMz0ExQJf5CBZ8aw9W2sxgWWPOAtrXY2localhost).

Description

Follow up from ~~MDL-76478~~ which fixed formslib. This applies the same markup to password admin settings.

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

image-2023-03-14-08-11-44-328.png
58 kB
14/Mar/23 8:11 PM
image-2023-03-14-08-13-14-983.png
73 kB
14/Mar/23 8:13 PM
MDL-77618.png
2.78 MB
14/Apr/23 11:28 AM

Issue Links

has been marked as being related by

MDL-76478 Browsers auto-completing the user's password into inappropriate password unmask form fields

Closed

is duplicated by

MDL-77676 Add autocomplete="new-password" to admin_setting_configpasswordunmask

Closed

Activity

People

Assignee:: Brendan Heywood

Reporter:: Brendan Heywood

Peer reviewer:: Eric Katchan

Integrator:: Sara Arjona (@sarjona)

Tester:: Ron Carl Alfon Yu

Participants:: Brendan Heywood, CiBoT, Eric Katchan, Huong Nguyen, Przemek Kaszubski, Ron Carl Alfon Yu, Sara Arjona (@sarjona)

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Votes:: 3 Vote for this issue

Watchers:: 11 Start watching this issue

Dates

Created:: 14/Mar/23 7:19 AM

Updated:: 20/Apr/23 12:33 AM

Resolved:: 14/Apr/23 6:00 PM

Fix Release Date:: 24/Apr/23

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

2h 50m