[MDL-77659] core_reportbuilder\local\helpers\user_profile_fields_test.php tests fail when other user profile fields exist - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 4.0.7, 4.1.2
Fix Version/s: 4.0.8, 4.1.3
Component/s: Report builder, Unit tests
Labels:
- ci
- triaged

Affected Branches:
MOODLE_400_STABLE, MOODLE_401_STABLE
Fixed Branches:
MOODLE_400_STABLE, MOODLE_401_STABLE
Pull from Repository:
https://github.com/AnupamaSarjoshi/moodle.git
Pull 4.0 Branch:
~~MDL-77659~~_400
Pull 4.0 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_400_STABLE...AnupamaSarjoshi:moodle:MDL-77659_400
Pull 4.1 Branch:
~~MDL-77659~~_401
Pull 4.1 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_401_STABLE...AnupamaSarjoshi:moodle:MDL-77659_401
Pull Main Branch:
~~MDL-77659~~
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/master...AnupamaSarjoshi:moodle:MDL-77659
Testing Instructions:
Hide

Unzip the attached file local_fortest.zip into the local folder of your Moodle install. (It is a simple local plugin that defines a visible custom profile field with shortname 'catname' when it is installed.)

Initialise PHPUnit and run core_reportbuilder_testsuite

php admin/tool/phpunit/cli/init.php

vendor/bin/phpunit --testsuite core_reportbuilder_testsuite

Or, in case of using MDK:

mdk phpunit -r -s core_reportbuilder|

Verify that the tests pass.
Show
Unzip the attached file local_fortest.zip into the local folder of your Moodle install. (It is a simple local plugin that defines a visible custom profile field with shortname 'catname' when it is installed.) Initialise PHPUnit and run core_reportbuilder_testsuite php admin/tool/phpunit/cli/init.php vendor/bin/phpunit --testsuite core_reportbuilder_testsuite Or, in case of using MDK: mdk phpunit -r -s core_reportbuilder| Verify that the tests pass.

Description

The following PHPUnit tests in core_reportbuilder\local\helpers\user_profile_fields_test.php fail when other user profile fields exist

core_reportbuilder\local\helpers\user_profile_fields_test::test_get_columns
Failed asserting that actual size 7 matches expected size 6.
/var/www/html/reportbuilder/tests/local/helpers/user_profile_fields_test.php:87/var/www/html/lib/phpunit/classes/advanced_testcase.php:80

core_reportbuilder\local\helpers\user_profile_fields_test::test_get_filters
Failed asserting that actual size 7 matches expected size 6.
/var/www/html/reportbuilder/tests/local/helpers/user_profile_fields_test.php:157
/var/www/html/lib/phpunit/classes/advanced_testcase.php:80

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

400.png
74 kB
28/Mar/23 10:29 AM
401.png
77 kB
28/Mar/23 10:29 AM
local_fortest.zip
2 kB
20/Mar/23 9:38 PM
master.png
75 kB
28/Mar/23 10:29 AM

Issue Links

has been marked as being related by

MDL-62483 Should be harder to write fragile unit tests that make unwarranted assumptions about a new Moodle install

Open

Activity

People

Assignee:: Anupama Sarjoshi

Reporter:: Anupama Sarjoshi

Peer reviewer:: Mahmoud Kassaei

Integrator:: Sara Arjona (@sarjona)

Tester:: Ron Carl Alfon Yu

Participants:: Anupama Sarjoshi, CiBoT, Mahmoud Kassaei, Paul Holden, Ron Carl Alfon Yu, Sara Arjona (@sarjona), Tim Hunt

Votes:: 0 Vote for this issue

Watchers:: 5 Start watching this issue

Dates

Created:: 16/Mar/23 9:00 PM

Updated:: 28/Mar/23 11:59 PM

Resolved:: 28/Mar/23 11:59 PM

Fix Release Date:: 24/Apr/23

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

45m