Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-77676

Add autocomplete="new-password" to admin_setting_configpasswordunmask

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Duplicate
    • 3.11.13, 4.0.7, 4.1.1
    • None
    • None
    • MOODLE_311_STABLE, MOODLE_400_STABLE, MOODLE_401_STABLE

    Description

      Browsers have recently started autocompleting usernames and passwords into username and password fields where they have not previously been saved in the browser's autocomplete settings. Our users have encountered issues with this behavior when they are adding/editing content or a setting, and do not notice these fields being autocompleted where they should not be, cause those resources to break. For example, when adding an LTI tool directly from the activity chooser, the credentials should be pulled from the sitewide settings; however the user's browser settings are being input and saved inadvertently. In addition, when an admin user was changing a config for a plugin with a username field and a password field, their saved credentials were autocompleted and saved by mistake, and the particular plugin broke.

      Apparently, current browsers are now ignoring the autocomplete attribute when set to "off" or "false". However setting autocomplete="new-password" to the password fields resolves this issue. This attribute can be added directly to the admin/templates/setting_configpasswordunmask.mustache template.

      I'd be happy to push a patch if this proposed fix is acceptable. Thank you!

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              meltonml Michelle Melton
              David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo, David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo
              Votes:
              1 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: