Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-77732

Links added in the navbar do not receive focus/active behaviour (custommenuitems) on the Boost theme - Take 2

    XMLWordPrintable

Details

    • MOODLE_402_STABLE
    • MOODLE_403_STABLE
    • MDL-77732-master
    • Hide

      Testing I

      1. Apply the patch.
      2. Log in as admin.
      3. Go to Site administration → Appearance → Theme settings.
      4. Set the custommenuitems content to:

        Courses
        -All courses|/course/
        -Course search|/course/search.php
        -###
        -FAQ|https://example.org/faq
        -My Important Course|http://localhost:8000/course/view.php?id=4
        Mobile app|https://example.org/app|Download our app

      5. Save changes (maybe adapt the 'My Important Course' link so that it points to an URL of an existing course in your Moodle).
      6. Click on one of the sub items All courses, Course search, or My Important Course. In all of these cases verify that:
        1. The main menu item Courses is underlined with a blue line
        2. No other main item should have the blue line
        3. The sub-item in Courses that was clicked should have a Check icon on the left
        4. No other sub-item but the clicked one should have a Check icon.
      7. Click on the sub-item 'Course search' and perform a search. When you get the result page verify that:
        1. The main menu item Courses is still underlined with a blue line
        2. The sub-item Course search has the Check icon.

      Testing II

      Running Behat scenario "Persistent Overdue in course view" should pass

      Show
      Testing I Apply the patch. Log in as admin. Go to Site administration → Appearance → Theme settings. Set the custommenuitems content to: Courses -All courses|/course/ -Course search|/course/search.php -### -FAQ|https://example.org/faq -My Important Course|http://localhost:8000/course/view.php?id=4 Mobile app|https://example.org/app|Download our app Save changes (maybe adapt the 'My Important Course' link so that it points to an URL of an existing course in your Moodle). Click on one of the sub items All courses , Course search , or My Important Course . In all of these cases verify that: The main menu item Courses is underlined with a blue line No other main item should have the blue line The sub-item in Courses that was clicked should have a Check icon on the left No other sub-item but the clicked one should have a Check icon. Click on the sub-item 'Course search' and perform a search. When you get the result page verify that: The main menu item Courses is still underlined with a blue line The sub-item Course search has the Check icon. Testing II Running Behat scenario "Persistent Overdue in course view" should pass
    • 1
    • Team Hedgehog 2023 Sprint 1.3, Team Hedgehog 2023 Sprint 1.4, Team Hedgehog 2023 Sprint 2.0, Team Hedgehog 2023 Sprint 2.1, Team Hedgehog 2023 Sprint 2.2, Team Hedgehog 2023 Sprint 2.3

    Description

      Create as a follow-up of the original MDL-75908 which has been reverted by MDL-77721

      IMPORTANT: As an acceptance criteria the "Persistent Overdue in course view" scenario should not fail randomly, please launch a "50 reps" kind of build.
      Also, please include in the testing instructions the scenarios reported by Ilya and Mihail

      ORIGINAL DESCRIPTION OF MDL-75908
      When you add internal links to the platform in the custommenuitems option and follow these links, they are not underlined as for the native links of the navigation bar.

      On this screen I added this value to the setting custommenuitemsthis :

      Catalog|/course/index.php

      The new link is therefore correctly displayed in my navbar however once I'm on the page, although present in the navbar, the link is not underlined and it is the link to the homepage which is.

      Attachments

        Issue Links

          Activity

            People

              strobotta Stephan Robotta
              lameze Simey Lameze
              Meirza Meirza
              Huong Nguyen Huong Nguyen
              Kim Jared Lucas Kim Jared Lucas
              Votes:
              0 Vote for this issue
              Watchers:
              12 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 hour, 30 minutes
                  1h 30m

                  Clockify

                    Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.