Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-77793

Remove the legacy theme selector

    XMLWordPrintable

Details

    • MOODLE_403_STABLE
    • MOODLE_403_STABLE
    • MDL-77793-master
    • Hide

      Setup

      It is worth noting that the upgrade step of this patch will attempt to remove any device related theme fields from the DB config table. To test this:

      1. Go to Site administration -> Appearance -> Theme selector
      2. Set a theme for each device (tablet, mobile, legacy).
      3. With a DB editor, observe the fields inside the config table called 'themelegacy', 'thememobile' and 'themetablet'.
      4. Trigger the upgrade process using this patch.
      5. CONFIRM that 'themelegacy', 'thememobile' and 'themetablet' fields have been removed.

      Main test

      1. Log in as Admin
      2. Go to Site administration -> Appearance -> Theme selector
      3. CONFIRM that you see a list of the available themes.
      4. CONFIRM you see the 'Use theme' button on themes that are not the current theme.
      5. Click on one of the inactive themes by using the 'Use theme' button.
      6. CONFIRM that the theme changes.
      7. CONFIRM you see a 'success' notification indicating your theme has changed.
      8. CONFIRM there is no 'sesskey' param in the URL.
      9. Click the 'Clear theme caches' button.
      10. CONFIRM there is no 'sesskey' param in the URL.
      Show
      Setup It is worth noting that the upgrade step of this patch will attempt to remove any device related theme fields from the DB config table. To test this: Go to Site administration -> Appearance -> Theme selector Set a theme for each device (tablet, mobile, legacy). With a DB editor, observe the fields inside the config table called 'themelegacy', 'thememobile' and 'themetablet'. Trigger the upgrade process using this patch. CONFIRM that 'themelegacy', 'thememobile' and 'themetablet' fields have been removed. Main test Log in as Admin Go to Site administration -> Appearance -> Theme selector CONFIRM that you see a list of the available themes. CONFIRM you see the 'Use theme' button on themes that are not the current theme. Click on one of the inactive themes by using the 'Use theme' button. CONFIRM that the theme changes. CONFIRM you see a 'success' notification indicating your theme has changed. CONFIRM there is no 'sesskey' param in the URL. Click the 'Clear theme caches' button. CONFIRM there is no 'sesskey' param in the URL.
    • 6
    • Team Hedgehog 2023 Sprint 2.1, Team Hedgehog 2023 Sprint 2.2

    Description

      This page needs to burn in a fire, with napalm added.

      It is an absolute atrocity and should have been removed ten years ago when we switched to a bootstrap-based theme with mobile-first design.

      We should:

      • remove it
      • remove all current values for mobile, tablet, legacy
      • dance around the ashes of those bytes as they burn in joyous serendipity
      • say prayers to our preferred deity or deities that we never make such a turd of a mistake ever again

      For reference, this is the abomination to which I refer:

      NOTE

      After discussions with UI, it has been agreed that the 'confirmation' page, after selecting a theme, can be removed. It will be replace with a confirmation notification. There will be a follow-up issue in the future to address further improvements to the theme selection that would currently be out of scope for this issue.

      Attachments

        1. 77793-death-to-device-themes.png
          77793-death-to-device-themes.png
          1.91 MB
        2. horizontal_scroll.png
          horizontal_scroll.png
          775 kB
        3. MDL-77793.png
          MDL-77793.png
          920 kB
        4. theme_selection.png
          theme_selection.png
          490 kB

        Issue Links

          Activity

            People

              david.woloszyn@moodle.com David Woloszyn
              dobedobedoh Andrew Lyons
              Huong Nguyen Huong Nguyen
              Andrew Lyons Andrew Lyons
              Ron Carl Alfon Yu Ron Carl Alfon Yu
              Votes:
              4 Vote for this issue
              Watchers:
              11 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 2 days, 5 hours, 15 minutes
                  2d 5h 15m

                  Clockify

                    Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.