[MDL-77856] HTML parsing error related to qtype_multianswer feedback in its subquestions - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 4.0.7, 4.1.2
Fix Version/s: 4.0.8, 4.1.3
Component/s: Accessibility, Questions
Labels:
- ci
- release_notes
- triaged

Affected Branches:
MOODLE_400_STABLE, MOODLE_401_STABLE
Fixed Branches:
MOODLE_400_STABLE, MOODLE_401_STABLE
Epic Link:
Moodle 4.0 Accessibility Audit
Pull from Repository:
https://github.com/junpataleta/moodle.git
Pull 4.0 Branch:
~~MDL-77856~~-400
Pull 4.0 Diff URL:
https://github.com/junpataleta/moodle/compare/8400206468...MDL-77856-400
Pull 4.1 Branch:
~~MDL-77856~~-401
Pull 4.1 Diff URL:
https://github.com/junpataleta/moodle/compare/a78f3a02c6...MDL-77856-401
Pull Master Branch:
~~MDL-77856~~-master
Pull Master Diff URL:
https://github.com/junpataleta/moodle/compare/fba0658777...MDL-77856-master
Testing Instructions:
Hide

Log in as an admin and restore multianswerquizcourse.mbz

Enrol students in the test course.

As a student, attempt the Multi-answer quiz

Submit and finish the quiz.

Review the attempt.

Tab through the feedback icons for each answer field (either check mark or x mark)

Confirm that a popover that contains the feedback to the answer field is being shown.
Show
Log in as an admin and restore multianswerquizcourse.mbz Enrol students in the test course. As a student, attempt the Multi-answer quiz Submit and finish the quiz. Review the attempt. Tab through the feedback icons for each answer field (either check mark or x mark) Confirm that a popover that contains the feedback to the answer field is being shown.

Description

While the quiz attempt review page is being rechecked for accessibility fixes from the accessibility audit, an HTML parsing issue related to qtype_multianswer's feedback area was raised. The issue found points to the feedback popover where the YUI Overlay widget encloses the feedback content within a div in a div. This results in a block element (div) being nested in an inline element (span).

Success criterion affected: Level A 4.1.1

Note: This does not affect multiple-choice subquestions as the feedback for these subquestions are being shown directly after the subquestion.

Screenshot from the accessibility tester:

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

MDL-77856.png
375 kB
13/Apr/23 4:28 PM
multianswerquizcourse.mbz
872 kB
06/Apr/23 12:05 AM
span in div.png
152 kB
05/Apr/23 10:46 PM

Issue Links

caused a regression

MDL-78033 MDL-77856 removed ability to see correct answers for qtype_multianswer with sub-question style applied

Open

MDL-78125 Feedback Modal not showing on quiz - Embedded answers (Cloze)

Closed

MDL-78549 cloze question: Correct answer is not displayed

Closed

MOBILE-4338 Fix inline quiz feedback

Closed

is duplicated by

MDL-77853 HTML parsing error related to qtype_multianswer feedback

Closed

MDL-77854 HTML parsing error related to qtype_multianswer feedback

Closed

MDL-77855 HTML parsing error related to qtype_multianswer feedback

Closed

(2 is duplicated by)

Activity

People

Assignee:: Jun Pataleta

Reporter:: Jun Pataleta

Peer reviewer:: Tim Hunt

Integrator:: Sara Arjona (@sarjona)

Tester:: Ron Carl Alfon Yu

Participants:: CiBoT, Juan Leyva, Jun Pataleta, Noel De Martin, Ron Carl Alfon Yu, Sara Arjona (@sarjona), Tim Hunt

Component watchers:: Jun Pataleta, Safat Shahin, Tim Hunt, Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie

Votes:: 0 Vote for this issue

Watchers:: 6 Start watching this issue

Dates

Created:: 05/Apr/23 10:33 PM

Updated:: 11/Jul/23 11:06 AM

Resolved:: 14/Apr/23 6:00 PM

Fix Release Date:: 24/Apr/23

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

4h 5m