Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-77858

Fix invalid "exception" imports from core/notification

XMLWordPrintable

      As reported in MDL-75316:

      displayException isn't a valid import name. We're importing that, but it's not an export in Notification. We need to import exception and alias that if we want to call it displayException.

      E.g.

      import {exception as displayException, addNotification} from 'core/notification';

      It looks like we've already introduced the same problem in core in 2 other places, so I'm going to suggest please creating an issue to fix those too.

      1. https://github.com/moodle/moodle/blob/fba0658777a10d553076c815a7f6a336ff0bbdb9/calendar/amd/src/manage_subscriptions.js#L29
      2. https://github.com/moodle/moodle/blob/fba0658777a10d553076c815a7f6a336ff0bbdb9/lib/editor/tiny/plugins/equation/amd/src/ui.js#L30

      Kind of similar to MDL-76491 (also about invalid imports from core/notification)

            pholden Paul Holden
            pholden Paul Holden
            Jake Dallimore Jake Dallimore
            Sara Arjona (@sarjona) Sara Arjona (@sarjona)
            Sara Arjona (@sarjona) Sara Arjona (@sarjona)
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 25 minutes
                25m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.