Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-77863

Hardcoded colors should be variables to make theme customisation easier

    XMLWordPrintable

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 4.1.2, 4.2.1
    • 4.3
    • HTML and CSS, Themes
    • MOODLE_401_STABLE, MOODLE_402_STABLE
    • MOODLE_403_STABLE
    • MDL-77863-master
    • Hide
      Setup
      1. Two identical Moodle sites (Site 1 with the patch, Site 2 without the patch)
      2. Quick regression test
        • As you go along the testing below, perform the same steps on both sites (e.g. from logging in to navigating/attempting the quiz and viewing the quiz reports)
        • And check that there are no colour changes between the two sites.
      General table sticky column background colour check
      1. Log in as a teacher and create a quiz in a course
      2. Log in as a student and attempt the quiz
      3. As a teacher view the Results page of the quiz and check out the attempts table.
      4. Compare this table to the quiz attempts report page of another Moodle instance without the patch.
      5. Confirm that the tables look basically the same in terms of colour.
      Show
      Setup Two identical Moodle sites (Site 1 with the patch, Site 2 without the patch) Quick regression test As you go along the testing below, perform the same steps on both sites (e.g. from logging in to navigating/attempting the quiz and viewing the quiz reports) And check that there are no colour changes between the two sites. General table sticky column background colour check Log in as a teacher and create a quiz in a course Log in as a student and attempt the quiz As a teacher view the Results page of the quiz and check out the attempts table. Compare this table to the quiz attempts report page of another Moodle instance without the patch. Confirm that the tables look basically the same in terms of colour.

    Description

      There is a lot of hardcoded color values in the Boost theme which makes the the customization of the theme and children theme a lot more complicated that it needs to be.

      These values should be moved into variables.

      Attachments

        Issue Links

          has a non-specific relationship to

          Epic - Created by Jira Software - do not edit or delete. Issue type for a big user story that needs to be broken down. MDL-71979 Upgrade boost to use Bootstrap 5.2

          • Minor - Minor loss of function where workaround is possible
          • Open
          has been marked as being related by

          Improvement - An enhancement to an existing Moodle feature. MDL-74869 Activity icon colors should be SCSS variables so they are easy to override.

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Activity

            People

              benjamin-unige Benjamin-unige
              benjamin-unige Benjamin-unige
              Luca Bösch Luca Bösch
              Jun Pataleta Jun Pataleta
              Ron Carl Alfon Yu Ron Carl Alfon Yu
              Amy Groshek, David Scotson, David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo, Huong Nguyen, Bas Brands, Mathew May, Amaia Anabitarte, Carlos Escobedo, Laurent David, Mikel Martín Corrales, Sabina Abellan, Sara Arjona (@sarjona)
              Votes:
              11 Vote for this issue
              Watchers:
              10 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                9/Oct/23

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 6 hours, 6 minutes
                  6h 6m