Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-77863

Convert hardcoded colors to use variables to make theme customisation easier

XMLWordPrintable

    • MOODLE_401_STABLE, MOODLE_402_STABLE
    • MOODLE_403_STABLE
    • MDL-77863-master
    • Hide
      Setup
      1. Two identical Moodle sites (Site 1 with the patch, Site 2 without the patch)
      2. Quick regression test
        • As you go along the testing below, perform the same steps on both sites (e.g. from logging in to navigating/attempting the quiz and viewing the quiz reports)
        • And check that there are no colour changes between the two sites.
      General table sticky column background colour check
      1. Log in as a teacher and create a quiz in a course
      2. Log in as a student and attempt the quiz
      3. As a teacher view the Results page of the quiz and check out the attempts table.
      4. Compare this table to the quiz attempts report page of another Moodle instance without the patch.
      5. Confirm that the tables look basically the same in terms of colour.
      Show
      Setup Two identical Moodle sites (Site 1 with the patch, Site 2 without the patch) Quick regression test As you go along the testing below, perform the same steps on both sites (e.g. from logging in to navigating/attempting the quiz and viewing the quiz reports) And check that there are no colour changes between the two sites. General table sticky column background colour check Log in as a teacher and create a quiz in a course Log in as a student and attempt the quiz As a teacher view the Results page of the quiz and check out the attempts table. Compare this table to the quiz attempts report page of another Moodle instance without the patch. Confirm that the tables look basically the same in terms of colour.

      There is a lot of hardcoded color values in the Boost theme which makes the the customization of the theme and children theme a lot more complicated that it needs to be.

      These values should be moved into variables.

        1. MDL-77863.png
          MDL-77863.png
          2.41 MB

            benjamin-unige Benjamin-unige
            benjamin-unige Benjamin-unige
            Luca Bösch Luca Bösch
            Jun Pataleta Jun Pataleta
            Ron Carl Alfon Yu Ron Carl Alfon Yu
            Votes:
            11 Vote for this issue
            Watchers:
            10 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 6 hours, 6 minutes
                6h 6m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.