Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-78029

A long-term solution for 3 properties in the stored_file class

    XMLWordPrintable

Details

    • Improvement
    • Resolution: Won't Fix
    • Minor
    • None
    • 4.2
    • Libraries
    • MOODLE_402_STABLE

    Description

      While working on MDL-77340, I received feedback from reviewers on adding the following properties:

      • $portfoliobutton
      • $timemodified and
      • $fileurl

      to the stored_file class, which is not appropriate.

      P. lib/filestorage/stored_file.php. I don't think it's a good idea to add $portfoliobutton, $timemodified and $fileurl to this class. Could you please review the places where it's used and check if they can be written in a different way to avoid adding them to the class?

      However, all three properties are needed in several other classes:

      • $portfoliobutton: mod/assign/renderable.php, mod/assign/classes/output/renderer.php
      • $timemodified: mod/assign/renderable.php, mod/assign/classes/output/renderer.php
      • $fileurl: mod/assign/classes/output/renderer.php, mod/workshop/renderer.php, repository/lib.php

      In order not to become a blocker, MDL-77340 is only a temporary solution. This issue is created to fix this problem so that it becomes a long-term solution, and after completion, the three properties must be removed from the stored_file class.

      Attachments

        Issue Links

          Activity

            People

              dobedobedoh Andrew Lyons
              meirza.arson@moodle.com Meirza
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 30 minutes
                  30m

                  Clockify

                    Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.