Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-7803

mod/data/view.php doesn't close all HTML tables

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.6.3
    • Fix Version/s: 1.9
    • Labels:
      None
    • Affected Branches:
      MOODLE_16_STABLE
    • Fixed Branches:
      MOODLE_19_STABLE

      Description

      In mod/data/view.php the confirm page for deleting an item from the database activity leaves an HTML table open. We use some CSS positioning to get the footer of our theme to always sit against the bottom of the viewport/bottom of the page and the missing closing tags cause this to break (that's how I noticed it, I don't make a habit of looking through source code counting matching tags )

      I'm not sure if this is exactly the right way to fix the problem, but inserting the missing </td></tr></table> just before the call to print_footer($course); round about line 235 seems to solve the issues I was seeing.

        Attachments

          Activity

            People

            Assignee:
            skodak Petr Skoda
            Reporter:
            catbert Andrew Walker
            Tester:
            Nobody
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              3/Mar/08