Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-78090

Moodle 5.0 core_question final deprecations

XMLWordPrintable

    • MOODLE_403_STABLE
    • MOODLE_500_STABLE
    • MDL-78090_core_question-final-deprecations
    • Hide
      1. Execute the following:

        git grep -n -C2 -P '(?<!\w)action_column_base' -- ':!*upgrade.txt' ':!.upgradenotes'
        git grep -n -C2 -P '(?<!\w)menu_action_column_base' -- ':!*upgrade.txt' ':!.upgradenotes'
        git grep -n -C2 -P '(?<!\w)menuable_action' -- ':!*upgrade.txt' ':!.upgradenotes'

      2. Confirm there are no matches.
      3. Execute the following:

        git grep -n -C2 -E 'print_choose_category_message\(' -- ':!.upgradenotes'
        git grep -n -C2 -E 'display_advanced_search_form\(' -- ':!.upgradenotes'
        git grep -n -C2 -E 'display_showtext_checkbox\(' -- ':!.upgradenotes'
        git grep -n -C2 -E 'init_search_conditions\(' -- ':!.upgradenotes'
        git grep -n -C2 -E 'get_current_category\(' -- ':!.upgradenotes'
        git grep -n -C2 -E 'display_options_form\(' -- ':!*upgrade.txt' ':!.upgradenotes'
        git grep -n -C2 -E 'start_table\(' -- ':!.upgradenotes'
        git grep -n -C2 -E 'end_table\(' -- ':!.upgradenotes'
        git grep -n -C2 'TIME_TO_CACHE' -- ':!*upgrade.txt' ':!.upgradenotes'
        git grep -n -C2 -P 'render(_hidden|_category)?_condition(_advanced)?\(' -- ':!.upgradenotes'

      4. Confirm the only matches are the original methods (which emit final deprecation notices) and upgrade notes regarding removal. There may be some false positives.
      5. Execute the following:

        git grep -n -C2 -E 'calculate_average_question_discriminative_efficiency\(' -- ':!.upgradenotes'
        git grep -n -C2 -E 'calculate_average_question_discrimination_index\(' -- ':!.upgradenotes'
        git grep -n -C2 -E 'get_all_places_where_questions_were_attempted\(' -- ':!.upgradenotes' ':!*statistics_bulk_loader*.php'
        git grep -n -C2 -E 'calculate_average_question_stats_item\(' -- ':!.upgradenotes'
        git grep -n -C2 -E 'calculate_average_question_facility\(' -- ':!.upgradenotes' ':!*statistics_bulk_loader*.php'
        git grep -n -C2 -E 'load_statistics_for_place\(' -- ':!.upgradenotes' ':!*statistics_bulk_loader*.php'
        git grep -n -C2 -E 'extract_item_value\(' -- ':!.upgradenotes' ':!*statistics_bulk_loader*.php'
        

      6. Confirm the only matches are the original methods (which emit final deprecation notices) and upgrade notes regarding removal.
      7. Execute the following:

        git grep -n -C2 -E 'qbank_managecategories/category_condition_advanced' -- ':!.upgradenotes'
        git grep -n -C2 -E 'qbank_managecategories/category_condition' -- ':!.upgradenotes'
        git grep -n -C2 -E 'qbank_managecategories/listitem' -- ':!.upgradenotes'

      8. Confirm there are no matches.
      Show
      Execute the following: git grep -n -C2 -P '(?<!\w)action_column_base' -- ':!*upgrade.txt' ':!.upgradenotes' git grep -n -C2 -P '(?<!\w)menu_action_column_base' -- ':!*upgrade.txt' ':!.upgradenotes' git grep -n -C2 -P '(?<!\w)menuable_action' -- ':!*upgrade.txt' ':!.upgradenotes' Confirm there are no matches. Execute the following: git grep -n -C2 -E 'print_choose_category_message\(' -- ':!.upgradenotes' git grep -n -C2 -E 'display_advanced_search_form\(' -- ':!.upgradenotes' git grep -n -C2 -E 'display_showtext_checkbox\(' -- ':!.upgradenotes' git grep -n -C2 -E 'init_search_conditions\(' -- ':!.upgradenotes' git grep -n -C2 -E 'get_current_category\(' -- ':!.upgradenotes' git grep -n -C2 -E 'display_options_form\(' -- ':!*upgrade.txt' ':!.upgradenotes' git grep -n -C2 -E 'start_table\(' -- ':!.upgradenotes' git grep -n -C2 -E 'end_table\(' -- ':!.upgradenotes' git grep -n -C2 'TIME_TO_CACHE' -- ':!*upgrade.txt' ':!.upgradenotes' git grep -n -C2 -P 'render(_hidden|_category)?_condition(_advanced)?\(' -- ':!.upgradenotes' Confirm the only matches are the original methods (which emit final deprecation notices) and upgrade notes regarding removal. There may be some false positives. Execute the following: git grep -n -C2 -E 'calculate_average_question_discriminative_efficiency\(' -- ':!.upgradenotes' git grep -n -C2 -E 'calculate_average_question_discrimination_index\(' -- ':!.upgradenotes' git grep -n -C2 -E 'get_all_places_where_questions_were_attempted\(' -- ':!.upgradenotes' ':!*statistics_bulk_loader*.php' git grep -n -C2 -E 'calculate_average_question_stats_item\(' -- ':!.upgradenotes' git grep -n -C2 -E 'calculate_average_question_facility\(' -- ':!.upgradenotes' ':!*statistics_bulk_loader*.php' git grep -n -C2 -E 'load_statistics_for_place\(' -- ':!.upgradenotes' ':!*statistics_bulk_loader*.php' git grep -n -C2 -E 'extract_item_value\(' -- ':!.upgradenotes' ':!*statistics_bulk_loader*.php' Confirm the only matches are the original methods (which emit final deprecation notices) and upgrade notes regarding removal. Execute the following: git grep -n -C2 -E 'qbank_managecategories/category_condition_advanced' -- ':!.upgradenotes' git grep -n -C2 -E 'qbank_managecategories/category_condition' -- ':!.upgradenotes' git grep -n -C2 -E 'qbank_managecategories/listitem' -- ':!.upgradenotes' Confirm there are no matches.
    • Hide

      Fails against automated checks.

      Checked MDL-78090 using repository: https://github.com/ziegenberg/moodle

      Should these errors be fixed?

      Built on: Mon Apr 14 09:15:47 UTC 2025

      Show
      Fails against automated checks. Checked MDL-78090 using repository: https://github.com/ziegenberg/moodle main [branch: MDL-78090_core_question-final-deprecations | CI Job ] Error: Unable to fetch information from MDL-78090 _core_question-final-deprecations branch at https://github.com/ziegenberg/moodle . Should these errors be fixed? Built on: Mon Apr 14 09:15:47 UTC 2025
    • Hide

      Launching automatic jobs for branch MDL-78090_core_question-final-deprecations

      Built on: Wed Mar 12 03:05:27 UTC 2025

      Show
      Launching automatic jobs for branch MDL-78090 _core_question-final-deprecations https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63490/ Behat (NonJS - boost and classic / --tags @core_question,@qbank,@mod_quiz) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63491/ Behat (Firefox - boost / --tags @core_question,@qbank,@mod_quiz) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63492/ Behat (Firefox - classic / --tags @core_question,@qbank,@mod_quiz) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63493/ App tests (stable app version) / --tags @core_question,@qbank,@mod_quiz) Built on: Wed Mar 12 03:05:27 UTC 2025

      This issue lists the final deprecations required in core_question in Moodle 4.7 now 5.0 since the release numbering scheme changed.

      • Remove the 4.3-deprecated methods from question/bank/statistics/classes/helper.php and related unit tests.
      • Remove the 4.3-deprecated constants from question/classes/statistics/questions/all_calculated_for_qubaid_condition.php and question/classes/statistics/responses/analyser.php.
      • Remove the 4.3-deprecated methods from question/bank/managecategories/classes/category_condition.php
      • Remove the 4.3-deprecated methods from question/renderer.php
      • Remove question/bank/managecategories/classes/output/renderer.php, and associated templates question/bank/managecategories/templates/category_condition.mustache and question/bank/managecategories/templates/category_condition_advanced.mustache
      • Remove unused template question/bank/managecategories/templates/listitem.mustache
      • Remove the 4.3-deprecated methods from question/classes/local/bank/view.php
      • Remove the action_column_base, menu_action_column_base classes and menuable_action interface from question/classes/local/bank

            Daniel Ziegenberg Daniel Ziegenberg
            timhunt Tim Hunt
            Tim Hunt Tim Hunt
            Andrew Lyons Andrew Lyons
            Kim Jared Lucas Kim Jared Lucas
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 58 minutes
                58m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.