Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-78091

Moodle 5.0 quiz final deprecations

XMLWordPrintable

    • Icon: Task Task
    • Resolution: Unresolved
    • Icon: Minor Minor
    • 5.1
    • 4.3
    • Quiz
    • MOODLE_403_STABLE
    • MOODLE_501_STABLE
    • MDL-78091_final-deprecations-for-quiz
    • Hide
      1. Execute the following:

        git grep -C2 -E 'add_random_form'

      2. Confirm the only matches are the initially deprecated JavaScript for the mod_quiz\form\add_random_form class and upgrade notes regarding removal.

        git grep -n -C2 -P '(?<!\w)set_tags(?:_by_id)?\('
        git grep -C2 TIME_TO_CACHE
        git grep -C2 -E 'quiz_add_random_questions\('
        

      3. Confirm the only matches are the original methods (which emit final deprecation notices) and upgrade notes regarding removal. There may be some false positives.
      4. Execute the following:

        git grep -C2 -E 'display_top_pagnation\('
        git grep -C2 -E 'display_bottom_pagination\('git grep -C2 -E 'get_questions_from_categories_with_usage_counts\('
        git grep -C2 -E 'get_questions_from_categories_and_tags_with_usage_counts\('git grep -C2 -E 'get_next_question_id\('
        git grep -C2 -E 'get_category_key\('
        git grep -C2 -E 'ensure_questions_for_category_loaded\('
        git grep -C2 -E 'get_question_ids\('
        git grep -C2 -E 'is_question_available\('git grep -C2 -E 'get_questions\('
        git grep -C2 -E 'count_questions\(' 

      5. Confirm the only matches are the original methods (which emit final deprecation notices) and upgrade notes regarding removal. There are some false positives for the last two functions.
      6. Execute the following

        git grep -C2 -E 'render_question_pagination\('

      7. Confirm it returns only the initial deprecation of render_question_pagination() and the upgrade notes regarding of said initial deprecation.
      8. Execute the following

        git grep -C2 MDL-78091'

      9. Confirm it returns no TODOs.
      10. Execute the following

         git grep -C2 -E 'random_question_form_preview(_question_list)?'

      11. Confirm it returns only the initial deprecation of random_question_form_preview, random_question_form_preview_question_list and the upgrade notes regarding of said initial deprecation.
      Show
      Execute the following: git grep -C2 -E 'add_random_form' Confirm the only matches are the initially deprecated JavaScript for the mod_quiz\form\add_random_form class and upgrade notes regarding removal. git grep -n -C2 -P '(?<!\w)set_tags(?:_by_id)?\(' git grep -C2 TIME_TO_CACHE git grep -C2 -E 'quiz_add_random_questions\(' Confirm the only matches are the original methods (which emit final deprecation notices) and upgrade notes regarding removal. There may be some false positives. Execute the following: git grep -C2 -E 'display_top_pagnation\(' git grep -C2 -E 'display_bottom_pagination\('git grep -C2 -E 'get_questions_from_categories_with_usage_counts\(' git grep -C2 -E 'get_questions_from_categories_and_tags_with_usage_counts\('git grep -C2 -E 'get_next_question_id\(' git grep -C2 -E 'get_category_key\(' git grep -C2 -E 'ensure_questions_for_category_loaded\(' git grep -C2 -E 'get_question_ids\(' git grep -C2 -E 'is_question_available\('git grep -C2 -E 'get_questions\(' git grep -C2 -E 'count_questions\(' Confirm the only matches are the original methods (which emit final deprecation notices) and upgrade notes regarding removal. There are some false positives for the last two functions. Execute the following git grep -C2 -E 'render_question_pagination\(' Confirm it returns only the initial deprecation of render_question_pagination() and the upgrade notes regarding of said initial deprecation. Execute the following git grep -C2 MDL-78091' Confirm it returns no TODOs. Execute the following git grep -C2 -E 'random_question_form_preview(_question_list)?' Confirm it returns only the initial deprecation of random_question_form_preview , random_question_form_preview_question_list and the upgrade notes regarding of said initial deprecation.
    • Hide

      Code verified against automated checks.

      Checked MDL-78091 using repository: https://github.com/ziegenberg/moodle

      More information about this report

      Built on: Wed Apr 16 13:52:14 UTC 2025

      Show
      Code verified against automated checks. Checked MDL-78091 using repository: https://github.com/ziegenberg/moodle main (0 errors / 0 warnings) [branch: MDL-78091_final-deprecations-for-quiz | CI Job ] More information about this report Built on: Wed Apr 16 13:52:14 UTC 2025
    • Hide

      Launching automatic jobs for branch MDL-78091_final-deprecations-for-quiz

      Built on: Thu Apr 17 04:30:37 UTC 2025

      Show
      Launching automatic jobs for branch MDL-78091 _final-deprecations-for-quiz https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19063/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65179/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65180/ Behat (Firefox - boost) --> unrelated (can be ignored) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65181/ Behat (Firefox - classic) --> unrelated (can be ignored) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65182/ App tests (stable app version) --> unrelated (can be ignored) Built on: Thu Apr 17 04:30:37 UTC 2025

      This issue lists the final deprecations required in mod_quiz in Moodle 4.7 now 5.0 since the release numbering scheme changed.

      • mod/quiz/report/statistics/classes/calculator.php
      • mod/quiz/classes/local/structure/slot_random.php set_tags() and set_tags_by_id() methods
      • question/classes/local/bank/random_question_loader.php several deprecated methods

            Daniel Ziegenberg Daniel Ziegenberg
            timhunt Tim Hunt
            Andrew Gosali Andrew Gosali
            Tim Hunt Tim Hunt
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 2 hours, 45 minutes
                2h 45m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.