Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-78233

Failure of unittest test_update_capabilities_install_performance

    XMLWordPrintable

Details

    Description

      We see consistent failure of the test test_update_capabilities_install_performance() added in this commit https://github.com/moodle/moodle/commit/fe6a51265ae3f915b02d8f79dc3752884a323124 on MsSQL and Oracle.
      If you look at the DML functions for these databases, the function insert_records() just calls insert_record() in a loop and the change makes no effect on these databases.

      I suggest to at least skip this test on oracle and mssql

      Maybe the test needs to be re-thought, it sounds very fragile and results depend on a lot of unknown factors - additional capabilities or roles added by non-standard plugins, capabilities added in the future to the mod_forum, etc.

      Attachments

        Issue Links

          has a non-specific relationship to

          Improvement - An enhancement to an existing Moodle feature. MDL-62483 Should be harder to write fragile unit tests that make unwarranted assumptions about a new Moodle install

          • Minor - Minor loss of function where workaround is possible
          • Open
          is a regression caused by

          Improvement - An enhancement to an existing Moodle feature. MDL-76129 Improve upgrade/install performance relating to capabilities and settings

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Activity

            People

              Unassigned Unassigned
              marina Marina Glancy
              David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo
              Votes:
              1 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated: