Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-78237

TinyMCE: Source code modal offset

XMLWordPrintable

    • MOODLE_401_STABLE, MOODLE_402_STABLE
    • MOODLE_401_STABLE, MOODLE_402_STABLE
    • MDL-78237-401
    • MDL-78237-402
    • MDL-78237-master
    • Hide
      1. Login as an Admin
      2. ENSURE TinyMCE is set as your primary text editor. You can do this by going to Site admin -> Plugins -> Text editors -> Manage editors
      3. Bring up any page that has a text editor (e.g. Click on your user icon, choose profile, and click edit profile)
      4. Click on the editor's 'View' menu link and choose 'Source code'
      5. Shrink the height of your window so that the top of the modal touches the navbar.
      6. CONFIRM that the Modal dialog box does not get hidden under the navbar.
      7. CONFIRM that the Modal dialog footer buttons are not hidden and always visible.
      8. Close the modal and click on the editor's 'View' menu link and choose 'Fullscreen'
      9. Again, shrink the height of your window so that the top of the modal touches the navbar.
      10. CONFIRM that the Modal dialog box does not get hidden under the navbar.
      11. CONFIRM that the Modal dialog footer buttons are not hidden and always visible.
      12. Perform steps 3-11 on a mobile device.
      13. Perform the same tests on Classic (the navbar height is different)
      Show
      Login as an Admin ENSURE TinyMCE is set as your primary text editor. You can do this by going to Site admin -> Plugins -> Text editors -> Manage editors Bring up any page that has a text editor (e.g. Click on your user icon, choose profile , and click edit profile ) Click on the editor's 'View' menu link and choose 'Source code' Shrink the height of your window so that the top of the modal touches the navbar. CONFIRM that the Modal dialog box does not get hidden under the navbar. CONFIRM that the Modal dialog footer buttons are not hidden and always visible. Close the modal and click on the editor's 'View' menu link and choose 'Fullscreen' Again, shrink the height of your window so that the top of the modal touches the navbar. CONFIRM that the Modal dialog box does not get hidden under the navbar. CONFIRM that the Modal dialog footer buttons are not hidden and always visible. Perform steps 3-11 on a mobile device. Perform the same tests on Classic (the navbar height is different)
    • 2
    • Team Hedgehog 2023 Sprint 2.2, Team Hedgehog 2023 Sprint 2.3

      When viewing the "source code" for a TinyMCE editor in both the boost and classic themes, the top header bar sits over the top of the modal

      The view source modal will need to be initialised with the correct size for the window taking into account the header bar. SImply applying a top offset doesn't scale the source modal window correctly

        1. boost_source_code.png
          boost_source_code.png
          162 kB
        2. classic_source_code.png
          classic_source_code.png
          158 kB
        3. MDL-78237.png
          MDL-78237.png
          235 kB
        4. Screenshot 2023-06-01 at 14.20.23.png
          Screenshot 2023-06-01 at 14.20.23.png
          680 kB

            david.woloszyn@moodle.com David Woloszyn
            matt.porritt@moodle.com Matt Porritt
            Stevani Andolo Stevani Andolo
            Andrew Lyons Andrew Lyons
            Ron Carl Alfon Yu Ron Carl Alfon Yu
            Votes:
            2 Vote for this issue
            Watchers:
            7 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 5 hours, 58 minutes
                5h 58m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.