Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-78274

Vertically center the feedback modal in grader report

XMLWordPrintable

    • MOODLE_403_STABLE
    • MOODLE_403_STABLE
    • Hide

      As a developer:

      1. Open course/amd/src/activitychooser.js
      2. Change the ModalFactory.create(...) call
      3. Add verticallyCentered: false,
      4. Run grunt AMD if caching is turned on
      5. Open a course with editing mode on
      6. Open the activity chooser
      7. Confirm it is not vertically centered (Current behaviour)
      8. Edit the ModalFactory.create(...) call
      9. Set verticallyCentered: true,
      10. Run grunt AMD if caching is turned on
      11. Reload your browser
      12. Open the activity chooser
      13. Confirm it is vertically centered (New behaviour)

      As a regular user:

      1. Create a course with an assignment (ensure feedback comments are enabled) and a learner enrolled
      2. Add a submission to the assignment as the learner
      3. Navigate to the Learners' assignment as an Admin
      4. Add some feedback to the Learners' submission
      5. Navigate to the Grader grade report
      6. Click on the action menu for the assignment
      7. Select "View feedback"
      8. Confirm the modal is centered on the screen

       

      Show
      As a developer: Open course/amd/src/activitychooser.js Change the ModalFactory.create(...) call Add verticallyCentered: false, Run grunt AMD if caching is turned on Open a course with editing mode on Open the activity chooser Confirm it is not vertically centered (Current behaviour) Edit the ModalFactory.create(...) call Set verticallyCentered: true, Run grunt AMD if caching is turned on Reload your browser Open the activity chooser Confirm it is vertically centered (New behaviour) As a regular user: Create a course with an assignment (ensure feedback comments are enabled) and a learner enrolled Add a submission to the assignment as the learner Navigate to the Learners' assignment as an Admin Add some feedback to the Learners' submission Navigate to the Grader grade report Click on the action menu for the assignment Select "View feedback" Confirm the modal is centered on the screen  
    • 3
    • Team Alpha - Sprint 2 I2-2023

      By default, when creating a modal using the js module ‘core/modal_factory’ the modals are displayed at the top of the page. This is also the case with the feedback modal.

      It is more intuitive to users to see the modal vertically centered as a most common pattern which demands immediate attention.
      The aim of this issue is to vertically center the feedback modal on the page, but also include this feature first within the ‘core/modal_factory’ module as a configurable option. 

      Acceptance criteria:

      • Support for vertically centering a modal as a configurable option in  ‘core/modal_factory’.
      • The feedback modal in the grader report is vertically centered on the page.

        1. (I) Passed -- (Master)MDL-78274.png
          (I) Passed -- (Master)MDL-78274.png
          125 kB
        2. (II) Passed -- (Master)MDL-78274.png
          (II) Passed -- (Master)MDL-78274.png
          104 kB
        3. 78274 border.png
          78274 border.png
          1.96 MB
        4. 78274 box model.png
          78274 box model.png
          2.75 MB
        5. feedback-modal-vertical-alignment.png
          feedback-modal-vertical-alignment.png
          594 kB

            mathewmay Mathew May
            Geshoski Mihail Geshoski
            Mihail Geshoski Mihail Geshoski
            Andrew Lyons Andrew Lyons
            Kim Jared Lucas Kim Jared Lucas
            Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - 1 day, 3 hours, 45 minutes
                1d 3h 45m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 3 hours, 51 minutes Time Not Required
                3h 51m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.