Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-78306

Convert core/modal and remaining legacy uses to ESM

XMLWordPrintable

    • MOODLE_403_STABLE
    • MOODLE_403_STABLE
    • MDL-78306-master
    • Hide

      Almost all of these are tested well by behat. If they are broken, they simply will not even open.

      Here is some exploratory testing for some of the things which are not as well tested:

      1. Navigate to a course
      2. Open the '...' menu for a section
      3. Choose "Permalink"
      4. Confirm that the Permalink modal opened
      1. From the user menu, select "Profile"
      2. Edit your profile
      3. Find the editor
      4. Open the H5P plugin
      5. Confirm the modal opened
      6. Close it
      7. Open the Link plugin
      8. Confirm the modal opened
      9. Close it
      10. Open the Equeation editor plugin
      11. Confirm the modal opened
      12. Close it
      13. Open the RecordRTC Audio plugin
      14. Confirm you can record Audio
      15. Open the RecordRTC Video plugin
      16. Confirm you can record Video

      Note: The RecordRTC plugins require you to be using the localhost domain

      Data registry
      1. Go to Site administration > Users > Privacy > Data registry
      2. Click on the + button to add a new category.
      Show
      Almost all of these are tested well by behat. If they are broken, they simply will not even open. Here is some exploratory testing for some of the things which are not as well tested: Navigate to a course Open the '...' menu for a section Choose "Permalink" Confirm that the Permalink modal opened From the user menu, select "Profile" Edit your profile Find the editor Open the H5P plugin Confirm the modal opened Close it Open the Link plugin Confirm the modal opened Close it Open the Equeation editor plugin Confirm the modal opened Close it Open the RecordRTC Audio plugin Confirm you can record Audio Open the RecordRTC Video plugin Confirm you can record Video Note: The RecordRTC plugins require you to be using the localhost domain Data registry Go to Site administration > Users > Privacy > Data registry Click on the + button to add a new category.
    • 1
    • Team Hedgehog 2023 Sprint 2.1, Team Hedgehog 2023 Sprint 2.2

      As part of modernisation of AMD codebase, we should convert core/modal and any remaining AMD uses.

      Unfortunately this is not backwards compatible, but any code updated to consume it as a class is. That is to say that an existing AMD module which is consuming it as a class will not work, but if that code is updated to assume it is a class, it will continue work and will continue to work on the non-class variant.

        1. (I) Passed -- (Master)MDL-78306.png
          44 kB
          Kim Jared Lucas
        2. (II) Passed -- (Master)MDL-78306.png
          454 kB
          Kim Jared Lucas
        3. (III) Passed -- (Master)MDL-78306.png
          89 kB
          Kim Jared Lucas
        4. dataregistry_modal_breakage.png
          126 kB
          Jun Pataleta

            dobedobedoh Andrew Lyons
            dobedobedoh Andrew Lyons
            Huong Nguyen Huong Nguyen
            Jun Pataleta Jun Pataleta
            Kim Jared Lucas Kim Jared Lucas
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 day, 19 minutes
                1d 19m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.