Moodle
  1. Moodle
  2. MDL-7830

Enrolment key notice displays first listed teacher

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.7
    • Fix Version/s: 1.7
    • Component/s: Enrolments
    • Labels:
      None
    • Environment:
      linux
    • Database:
      MySQL
    • Affected Branches:
      MOODLE_17_STABLE
    • Fixed Branches:
      MOODLE_17_STABLE
    • Rank:
      27661

      Description

      When using an enrolment key, the student is asked to supply the enrolment key provided by the first teacher listed in the course.

      Because of the new role system all teachers at the site or category level are listed.

      E.g.
      Grade 11 Biology (Currie/Woodland)

      • Teacher: Mrs. L. Cote
      • Teacher: Mrs. M. Orr
      • Teacher: Ms. M. Murphy
      • Teacher: Mr. L. Scanlan
      • Teacher: M. Woodland
      • Teacher: Mrs. J. Currie

      This course requires an 'enrolment key' - a one-time
      password that you should have received from Mrs. L. Cote.

      Should be:

      This course requires an 'enrolment key' - a one-time
      password that you should have received from Mrs. Currie.

        Activity

        Jeff Wood created issue -
        Hide
        Martin Dougiamas added a comment -

        If Currie is the "main" teacher, then you might want to create a new teacher role called something like "Head Teacher" (or something) for her (even if it has the same capabilities), and in the roles definition screen change the sortorder so that this role has higher precedence over "ordinary" teachers.

        This sort order affects the sorting anywhere roles are displayed, such as here on the enrolment page.

        Show
        Martin Dougiamas added a comment - If Currie is the "main" teacher, then you might want to create a new teacher role called something like "Head Teacher" (or something) for her (even if it has the same capabilities), and in the roles definition screen change the sortorder so that this role has higher precedence over "ordinary" teachers. This sort order affects the sorting anywhere roles are displayed, such as here on the enrolment page.
        Hide
        Martin Dougiamas added a comment -

        Apart from that I just described, there is no other way for Moodle to guess automatically who you want to be the contact person.

        The only other alternative would be to develop a new course setting so that the "contact person" could be defined.

        Show
        Martin Dougiamas added a comment - Apart from that I just described, there is no other way for Moodle to guess automatically who you want to be the contact person. The only other alternative would be to develop a new course setting so that the "contact person" could be defined.
        Hide
        Jeff Wood added a comment -

        Hi Martin,

        This doesn't make sense to me:

        Grade 11 University Prep Physics (Wood)

        Teacher: Mrs. L. Cote
        Teacher: Mrs. M. Orr
        Teacher: Ms. M. Murphy
        Teacher: Mr. L. Scanlan
        Administrator: Mr. J. Wood

        This course requires an 'enrolment key' - a one-time
        password that you should have received from Mrs. L. Cote.

        Doesn't the Admin role superceed the teacher role? Not sure why the Administrator wouldn't be listed as the enrolment key giver?

        Also, not sure where the sort order is anymore?! It used to be in the course under participants (if memory serves).

        For the course listed above the only teacher listed is the Admin - Mr. J. Wood

        Show
        Jeff Wood added a comment - Hi Martin, This doesn't make sense to me: Grade 11 University Prep Physics (Wood) Teacher: Mrs. L. Cote Teacher: Mrs. M. Orr Teacher: Ms. M. Murphy Teacher: Mr. L. Scanlan Administrator: Mr. J. Wood This course requires an 'enrolment key' - a one-time password that you should have received from Mrs. L. Cote. Doesn't the Admin role superceed the teacher role? Not sure why the Administrator wouldn't be listed as the enrolment key giver? Also, not sure where the sort order is anymore?! It used to be in the course under participants (if memory serves). For the course listed above the only teacher listed is the Admin - Mr. J. Wood
        Hide
        Jeff Wood added a comment -

        The really strange thing is, if you look at all the course in our science category, the names are all in different order.

        http://nccschool.org/course/category.php?id=2

        And i cannot find any way to change the order the names are in because one one name is the teach of the course, the others are "site wide" teachers (because they need edit rights on the main page).

        Show
        Jeff Wood added a comment - The really strange thing is, if you look at all the course in our science category, the names are all in different order. http://nccschool.org/course/category.php?id=2 And i cannot find any way to change the order the names are in because one one name is the teach of the course, the others are "site wide" teachers (because they need edit rights on the main page).
        Hide
        Jeff Wood added a comment -

        After looking at the information more closely. The last person on the list is the actual teacher of the course, while all the ones above are site level teachers.

        Show
        Jeff Wood added a comment - After looking at the information more closely. The last person on the list is the actual teacher of the course, while all the ones above are site level teachers.
        Hide
        James Ballard added a comment - - edited

        This is quite confusing if that person has nothing to do with students individually, which is often the case for site-wide users, who seem to be listed here when given a custom role with view course allowed (see MDL-11798). In some cases it is always the same person listed no matter what course and them receiving emails is not appropriate.

        One way around this is moving teacher above administrator in the role definitions list and then you get a random teacher named. Alternatively you can change the language string enrolmentkeyfrom and hard code a message there with appropriate support contacts.

        The former is not intuitive in terms of role hierarchies, and the latter is not flexible.

        I can't think of a good way of nominating the main tutor without having that somewhere in the course settings or role assignments, similar to selecting hidden assignments perhaps.

        Show
        James Ballard added a comment - - edited This is quite confusing if that person has nothing to do with students individually, which is often the case for site-wide users, who seem to be listed here when given a custom role with view course allowed (see MDL-11798 ). In some cases it is always the same person listed no matter what course and them receiving emails is not appropriate. One way around this is moving teacher above administrator in the role definitions list and then you get a random teacher named. Alternatively you can change the language string enrolmentkeyfrom and hard code a message there with appropriate support contacts. The former is not intuitive in terms of role hierarchies, and the latter is not flexible. I can't think of a good way of nominating the main tutor without having that somewhere in the course settings or role assignments, similar to selecting hidden assignments perhaps.
        Hide
        Helen Foster added a comment -

        Jeff, thanks for reporting this issue, and James, thanks for your comments.

        Please see the FAQ about changing the name of the person holding the enrolment key in http://docs.moodle.org/en/Enrolment_FAQ for two possible methods.

        Show
        Helen Foster added a comment - Jeff, thanks for reporting this issue, and James, thanks for your comments. Please see the FAQ about changing the name of the person holding the enrolment key in http://docs.moodle.org/en/Enrolment_FAQ for two possible methods.
        Helen Foster made changes -
        Field Original Value New Value
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s 1.7 [ 10120 ]
        QA Assignee tsala
        Resolution Fixed [ 1 ]
        Martin Dougiamas made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        QA Assignee tsala nobody
        Martin Dougiamas made changes -
        Workflow jira [ 18676 ] MDL Workflow [ 54430 ]
        Martin Dougiamas made changes -
        Workflow MDL Workflow [ 54430 ] MDL Full Workflow [ 83537 ]

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: