Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-78314

In 'Make comment or override mark' window, let the bottom buttons be not sticky to the previous element and omit final horizontal line

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • 4.0.9, 4.1.4, 4.2.1
    • 4.0.8, 4.1.3, 4.2
    • Quiz
    • MOODLE_400_STABLE, MOODLE_401_STABLE, MOODLE_402_STABLE
    • MOODLE_400_STABLE, MOODLE_401_STABLE, MOODLE_402_STABLE
    • MDL-78314-401
    • MDL-78314-master
    • Hide
      1. Test in Boost and Classic
      2. As teacher in a student's quiz attempt go to result and click a question's mark in the table to open the "Review response" ("Review of question") window.
      3. Click the "Make comment or override mark" link to open the "Manually grade question" window.
      4. Verify on the bottom the buttons do not stick to the previous element and that there is no superfluous line at the end (please ignore the buttons are sticking to the bottom of the Classic popup window, this isn't generally caused by this code here, and should be addressed in a separate issue).

      Show
      Test in Boost and Classic As teacher in a student's quiz attempt go to result and click a question's mark in the table to open the "Review response" ("Review of question") window. Click the "Make comment or override mark" link to open the "Manually grade question" window. Verify on the bottom the buttons do not stick to the previous element and that there is no superfluous line at the end (please ignore the buttons are sticking to the bottom of the Classic popup window, this isn't generally caused by this code here, and should be addressed in a separate issue).

      This UI is not visually nice.
      The "Manually grade question" should resemble the "Review of question".

      FULL STEPS
      As teacher, in a student's quiz attempt review, do 'Make comment or override mark'.

      WHAT YOU EXPECTED
      Clear interface with bottom buttons, distinguished, and no final line.

      WHAT ACTUALLY HAPPENS
      The buttons stick to the previous element and there's a final line for no reason apparently.

        1. classic_boost.png
          76 kB
          Stephan Robotta
        2. MDL-78314.png
          107 kB
          Luca Bösch
        3. MDL-78314-1.png
          164 kB
          Ron Carl Alfon Yu
        4. MDL-78314-after.png
          48 kB
          Luca Bösch
        5. MDL-78314-classic.png
          169 kB
          Luca Bösch

            lucaboesch Luca Bösch
            lucaboesch Luca Bösch
            Stephan Robotta Stephan Robotta
            Tim Hunt Tim Hunt
            Ron Carl Alfon Yu Ron Carl Alfon Yu
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour, 25 minutes
                1h 25m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.