Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-78335

Normalise the date completion criteria date string

    XMLWordPrintable

Details

    • Improvement
    • Resolution: Fixed
    • Minor
    • 4.4
    • 4.3
    • Course completion
    • MOODLE_403_STABLE
    • MOODLE_404_STABLE
    • MDL-78335-master
    • Hide
      1. Log in as admin
      2. Create a user
      3. Create a course
      4. Enrol user in course as student
      5. Navigate to course
      6. Navigate to More > Course completion from course navigation
      7. Expand Condition: Date and tick Enable
        • Date when course will be marked as complete: 1 December 2024
      8. Add Course completion status block to the course
      9. Confirm the Date information shows "1 Dec 2024"
      10. Press More details from the Course completion status block
      11. Confirm the Date passed requirement shows "1 Dec 2024"
      12. Go back to course and press View course report from the Course completion status block
      13. Confirm the Date criteria shows "1 Dec 2024"
      Show
      Log in as admin Create a user Create a course Enrol user in course as student Navigate to course Navigate to More > Course completion from course navigation Expand Condition: Date and tick Enable Date when course will be marked as complete: 1 December 2024 Add Course completion status block to the course Confirm the Date information shows "1 Dec 2024" Press More details from the Course completion status block Confirm the Date passed requirement shows "1 Dec 2024" Go back to course and press View course report from the Course completion status block Confirm the Date criteria shows "1 Dec 2024"

    Description

      This was noted by davidcarrillo in his review of MDL-75640:

      I also found similar places in the completion report and completion block that are not always consistent either - let's fix it in one place, and try to re-use that implementation everywhere

      We should use a language string defined in the current lang pack for formatting the dates. 1-June-27 is a very odd way of writing dates in English (I don't know how it looks in other languages)

      Attachments

        1. (1) 11 Passed -- (Master)MDL-79062.png
          (1) 11 Passed -- (Master)MDL-79062.png
          30 kB
        2. (1) 13 Passed -- (Master)MDL-79062.png
          (1) 13 Passed -- (Master)MDL-79062.png
          47 kB
        3. (1) 9 Passed -- (Master)MDL-79062.png
          (1) 9 Passed -- (Master)MDL-79062.png
          20 kB
        4. 1.png
          1.png
          15 kB
        5. 2.png
          2.png
          23 kB
        6. 3.png
          3.png
          26 kB
        7. photo_2023-05-23_10-42-19.jpg
          photo_2023-05-23_10-42-19.jpg
          17 kB

        Issue Links

          Discovered while testing

          Improvement - An enhancement to an existing Moodle feature. MDL-75640 Implement columns for completion criterias

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Activity

            People

              mohamed.shehata@moodle.com Mohamed Shehata
              pholden Paul Holden
              Paul Holden Paul Holden
              Amaia Anabitarte Amaia Anabitarte
              Kim Jared Lucas Kim Jared Lucas
              Votes:
              1 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 4 hours, 31 minutes
                  4h 31m