Prerequisites

1. Install tool_testtasks:

   git clone git@github.com:catalyst/moodle-tool_testtasks.git admin/tool/testtasks

2. Modify this patch so tasks get cleaned up quicker:
   1. Open lib/classes/task/manager.php
   2. In the cleanup_metadata method, look for:

      if ($runningtask->timestarted > time() - HOURSECS) {

      continue;

      }

   3. Modify it to:

      if ($runningtask->timestarted > time() - MINSECS) {

      continue;

      }

Testing

1. Browse to "Site administration" > "Server" > "Tasks running now" (you'll need to get back to this page quickly after the next steps)
2. Queue up 1 1000 second tasks:

   php admin/tool/testtasks/cli/queue_multiple_adhoc_tasks.php -n=1 -c="tool_testtasks\task\one_thousand_second_task"

3. Start processing the task:

   php admin/cli/adhoc_task.php -e

4. Kill the adhoc task runners in the terminal by pressing ctrl+z followed by the command: kill -9 %1
5. Refresh the "Tasks running now page" and verify you see 1000 second task processing
6. Run the cleanup task:

   php admin/cli/scheduled_task.php --execute=\\core\\task\\task_lock_cleanup_task

7. Verify the output contains "Marking orphaned adhoc task as failed: tool_testtasks\task\one_thousand_second_task (adhoc task id x)

Code verified against automated checks with warnings.

Checked MDL-78437 using repository: https://github.com/bwalkerl/moodle

• main (0 errors / 2 warnings) [branch: MDL-78437-cleanup-metadata | CI Job]
  • overview (0/0), phplint (0/0), phpcs (0/0), js (0/0), css (0/0), phpdoc (0/0), commit (0/2), savepoint (0/0), thirdparty (0/0), externalbackup (0/0), grunt (0/0), shifter (0/0), mustache (0/0), gherkin (0/0),

Should these errors be fixed?

Built on: Thu Apr 3 01:46:33 UTC 2025

Launching automatic jobs for branch MDL-78437-cleanup-metadata

• https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18906/ PHPUnit (sqlsrv)
• https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64723/ Behat (NonJS - boost and classic)
• https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64724/ Behat (Firefox - boost)
• https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64725/ Behat (Firefox - classic)
• https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64726/ App tests (stable app version)

Built on: Thu Apr 3 02:25:15 UTC 2025