Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-78459

Missing args when fetching site shortname with $CFG->enablesmartappbanners enabled

XMLWordPrintable

    • MOODLE_402_STABLE
    • MOODLE_401_STABLE, MOODLE_402_STABLE
    • MDL-78459-401
    • Hide
      1. Log in as admin
      2. Search administration for, and enable, the following settings:
        • enablemobilewebservice
        • enablesmartappbanners
      3. Tail your webserver error log, e.g.: 

        $ tail -f  /var/log/apache2/moodle-error.log

      4. Run the following command: 

        $ curl --silent "<WWWROOT>/admin/tool/mobile/mobile.webmanifest.php" | python -m json.tool

      5. Confirm no debugging messages were displayed in your error log
      6. Confirm presence of "short_name" property in returned data
      Show
      Log in as admin Search administration for, and enable, the following settings: enablemobilewebservice enablesmartappbanners Tail your webserver error log, e.g.: $ tail -f /var/log/apache2/moodle-error.log Run the following command: $ curl --silent "<WWWROOT>/admin/tool/mobile/mobile.webmanifest.php" | python -m json.tool Confirm no debugging messages were displayed in your error log Confirm presence of "short_name" property in returned data

      When enablesmartappbanners is on and you visit this page:

      https://master.localhost/admin/tool/mobile/mobile.webmanifest.php

      you get this log spam:

      NOTICE: PHP message: Debugging: Coding problem: $PAGE->context was not set. You may have forgotten to call require_login() or $PAGE->set_context(). The page may not display correctly as a result in "

      • line 567 of /lib/pagelib.php: call to debugging()"
      • line 962 of /lib/pagelib.php: call to moodle_page->magic_get_context()"
      • line 1506 of /lib/weblib.php: call to moodle_page->__get()"
      • line 43 of /admin/tool/mobile/mobile.webmanifest.php: call to format_string()"

       

      This page should also be NO_MOODLE_COOKIES

       

        1. test.png
          test.png
          28 kB
        2. MDL-78459.png
          MDL-78459.png
          111 kB

            pholden Paul Holden
            brendanheywood Brendan Heywood
            Brendan Heywood Brendan Heywood
            Huong Nguyen Huong Nguyen
            Ron Carl Alfon Yu Ron Carl Alfon Yu
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour
                1h

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.