Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-78460

Broken HTML coding in Forum timed posts modal

    XMLWordPrintable

Details

    • MOODLE_400_STABLE, MOODLE_401_STABLE, MOODLE_402_STABLE
    • MOODLE_401_STABLE, MOODLE_402_STABLE
    • MDL-78460-401
    • MDL-78460-402
    • Hide

      Manual test

      1. Log in as admin
      2. Create a new course
      3. Navigate to new course Announcements forum
      4. Press Add discussion topic, then Advanced
        • Subject: Blah
        • Message: Blurg
        • Display start: 1 January 2024
        • Display end: 1 February 2024
      5. Press Post to forum
      6. In subsequent discussion list, press the Timed label next to your new post
      7. Confirm the popup shows correctly formatted list (without unformatted HTML elements)

      Regression test (MDL-67392)

      1. Navigate to Language > Language customisation in site administration
      2. Select English (en), then Option language pack for editing
      3. Choose mod > forum.php from Show strings of these components
      4. Set String identifier to "displaystartdate"
      5. Press Show strings
      6. Set Local customisation to the following, and save: 

        Display it's "Start": {$a}

      7. Navigate back to new course announcements forum
      8. Press the Timed label next to your post
      9. Confirm the popup shows correctly formatted list (without unformatted HTML elements) with custom language string
      Show
      Manual test Log in as admin Create a new course Navigate to new course Announcements forum Press Add discussion topic , then Advanced Subject: Blah Message: Blurg Display start: 1 January 2024 Display end: 1 February 2024 Press Post to forum In subsequent discussion list, press the Timed label next to your new post Confirm the popup shows correctly formatted list (without unformatted HTML elements) Regression test ( MDL-67392 ) Navigate to Language > Language customisation in site administration Select English (en) , then Option language pack for editing Choose mod > forum.php from Show strings of these components Set String identifier to "displaystartdate" Press Show strings Set Local customisation to the following, and save: Display it's "Start": {$a} Navigate back to new course announcements forum Press the Timed label next to your post Confirm the popup shows correctly formatted list (without unformatted HTML elements) with custom language string

    Description

      Whenever creating a timed post in a forum, the 'Timed post' modal under this post displays start and end date for visibility (for authorised users).

      There is some broken HTML in this modal, as can be seen in the attached screenshot

      Because of this, the modal looks messy: \n tags shouldn't display, and HTML-tags should be handled properly, instead of appearing as <\/li>.

      This screenshot was taken in https://school.moodledemo.net.

      To reproduce:

      1. create a timed post in any forum
      2. set start and/or end date for the post
      3. save
      4. check in the discussions list whether the 'Timed' button appears, is clickable
      5. Click the Timed button to see how the settings are displayed.

      Attachments

        Issue Links

          has a non-specific relationship to

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-67392 Forum information about timed discussion doesn't handle correctly "displaystartdate" and "displayenddate" containing quotes

          • Minor - Minor loss of function where workaround is possible
          • Closed
          is a regression caused by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-75516 Mustache quote helper does not escape all special JSON characters

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Activity

            People

              pholden Paul Holden
              jwelshoff Joost Elshoff
              Mathew May Mathew May
              Mihail Geshoski Mihail Geshoski
              Kim Jared Lucas Kim Jared Lucas
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                14/Aug/23

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 hour, 36 minutes
                  1h 36m