Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Minor
Fix Version/s: 4.1.5, 4.2.2
Affects Version/s: 4.0.9, 4.0.10, 4.1.4, 4.1.5, 4.2.2
Component/s: Forms Library
Labels:
- ci
- triaged

Affected Branches:
MOODLE_400_STABLE, MOODLE_401_STABLE, MOODLE_402_STABLE
Fixed Branches:
MOODLE_401_STABLE, MOODLE_402_STABLE
Pull from Repository:
https://github.com/dasistwas/moodle.git
Pull 4.1 Branch:
~~MDL-78478~~-401
Pull 4.1 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_401_STABLE...dasistwas:moodle:MDL-78478-401
Pull Main Branch:
~~MDL-78478~~-master
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/master...dasistwas:moodle:MDL-78478-master
Testing Instructions:

Hide

I recommend to test on MOODLE 4.1 as the plugins used for testing have been tested with 4.1:

1) On a M4.1 Moodle install mod_booking from there:

https://github.com/Wunderbyte-GmbH/moodle-mod_booking/tree/USI

(Use the USI branch)

2) Install dependency from there

https://github.com/Wunderbyte-GmbH/moodle-local_wunderbyte_table/tree/USI

3) Go to "Website Administration -> Plugins -> Booking: Semester"

4) Click on "Add semester"

5) Without the fix an error will be shown (see attachment)

6) With the fix, the error is gone.

Show
I recommend to test on MOODLE 4.1 as the plugins used for testing have been tested with 4.1: 1) On a M4.1 Moodle install mod_booking from there: https://github.com/Wunderbyte-GmbH/moodle-mod_booking/tree/USI (Use the USI branch) 2) Install dependency from there https://github.com/Wunderbyte-GmbH/moodle-local_wunderbyte_table/tree/USI 3) Go to "Website Administration -> Plugins -> Booking: Semester" 4) Click on "Add semester" 5) Without the fix an error will be shown (see attachment) 6) With the fix, the error is gone.

Using repeated elements in dynamic forms do not work due to a faulty use of this.updateForm in lib/form/amd/src/dynamicform.js

Fix is already available.

How to reproduce:

When using a dynamic form and repeat_elements, add a repeated element like the one in the link below in your form. Then use the form:

https://github.com/Wunderbyte-GmbH/moodle-mod_booking/blob/687076c4556ce4893c71aa9edf6b37744c3d82fe/classes/form/dynamicsemestersform.php#L178

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

error-message.png
96 kB
14/Jun/23 10:44 PM
MDL-78478.png
252 kB
15/Jun/23 11:12 AM

has a non-specific relationship to

MDL-73205 AJAX exceptions thrown when submitting modal/dynamic forms never caught

Closed

Assignee:: David Bogner

Reporter:: David Bogner

Peer reviewer:: Paul Holden

Integrator:: Andrew Lyons

Tester:: Ron Carl Alfon Yu

Participants:: Andrew Lyons, CiBoT, David Bogner, Paul Holden, Ron Carl Alfon Yu

Votes:: 0 Vote for this issue

Watchers:: 4 Start watching this issue

Created:: 14/Jun/23 8:38 PM

Updated:: 16/Jun/23 2:22 PM

Resolved:: 16/Jun/23 2:22 PM

Estimated:

Not Specified

Remaining:

Logged:

1h 1m

Details

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify