Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-78541

admin_apply_default_settings() fails if heading has the same name as plugin setting

XMLWordPrintable

      I got bitten by this recently in multiple plugins, following code settings content does not apply the setting during behat ini causing behat failures due to missing settings.

      $settings->add(new admin_setting_heading('something', 'Something header', 'Desc'));
      $settings->add(new admin_setting_configcheckbox('mod_book/something', 'Enable', 'Other desc', '0'));

      The code in admin_apply_default_settings() is problematic, I am going to submit a small workaround patch only and then create a followup for master only.

            skodak Petr Skoda (Inactive)
            skodak Petr Skoda (Inactive)
            Farhan Karmali Farhan Karmali
            Andrew Lyons Andrew Lyons
            Kim Jared Lucas Kim Jared Lucas
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 30 minutes
                30m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.