Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-78567

The room topic in communication failed to save and raised an error while edited

    XMLWordPrintable

Details

    • MOODLE_403_STABLE
    • MOODLE_403_STABLE
    • MDL-78567-master
    • Hide

      Testing

      1. Create a new Moodle instance (master) and do not install it.
      2. Checkout to the previous weekly release before MDL-77357 by running: git checkout 84bb5725f8ac68032d70669e7255c557f35c34e4
      3. Install the site by running (for example, using mdk install)
      4. Navigate to site and complete any upgrades.
      5. Checkout to the latest master branch.
      6. Do the site upgrade.
      7. Go to Site administration > Experimental > Experimental settings
      8. Enable the communication subsystem. Save the changes
      9. Create a course with the Communication service field set to Matrix.
      10. Filled the room name and room topic with any value. Make sure that both are not empty. and then click the "Save and display" button
      11. You will be redirected to the course page.
      12. Click Settings to Edit the course.
      13. Go to "Communication" section
      14. Verify that the "Room topic" has its value
      15. Update the the value and save it
      16. Click on the settings again
      17. Verify that the "Room topic" value has been updated
      Show
      Testing Create a new Moodle instance (master) and do not install it. Checkout to the previous weekly release before MDL-77357 by running: git checkout 84bb5725f8ac68032d70669e7255c557f35c34e4 Install the site by running (for example, using mdk install ) Navigate to site and complete any upgrades. Checkout to the latest master branch. Do the site upgrade. Go to Site administration > Experimental > Experimental settings Enable the communication subsystem. Save the changes Create a course with the Communication service field set to Matrix. Filled the room name and room topic with any value. Make sure that both are not empty. and then click the "Save and display" button You will be redirected to the course page. Click Settings to Edit the course. Go to "Communication" section Verify that the "Room topic" has its value Update the the value and save it Click on the settings again Verify that the "Room topic" value has been updated
    • 2
    • Team Hedgehog 2023 Sprint 2.3

    Description

      Steps to replicate

      1. Create a new Moodle instance (master) and do not install it.
      2. Checkout to the previous weekly release before MDL-77357 by running: git checkout 84bb5725f8ac68032d70669e7255c557f35c34e4
      3. Install the site by running: mdk install.
      4. Navigate to site and complete any upgrades.
      5. Checkout to the latest master branch.
      6. Do the site upgrade.
      7. Go to Site administration > Experimental > Experimental settings
      8. Enable the communication subsystem. Save the changes
      9. Create a course with the Communication service field set to Matrix.
      10. Filled the room name and room topic with any value. Make sure that both are not empty. and then click the "Save and display" button
      11. You will be redirected to the course page.
      12. Click Settings to Edit the course.
      13. Right-click on the page and choose View page source
      14. Observe the top of the page.

      Expected result: There is no error.

      Actual result: There is an error: Undefined property: stdClass::$topic

       

       

      — Original steps to replicate —

      Two problems need to be fixed.

      To reproduce:

      1. Go to Site administration > Experimental > Experimental settings
      2. Enable the communication subsystem. Save the changes
      3. Create a course with the Communication service field set to Matrix.
      4. Filled the room name and room topic with any value. Make sure that both are not empty. and then click the "Save and display" button
      5. You will be redirected to the course page.
      6. Click Settings to Edit the course.
      7. Scrolled to the Communication fieldset
        • Expected
          • The room topic is filled by a value that you have set.
        • Actual
          • The room topic is empty
      8. Filled the room topic again. Save the changes
        • Expected
          • The room topic is successfully saved
        • Actual
          • Raising an error: Warning: Undefined property: stdClass::$topic in /communication/provider/matrix/classes/matrix_rooms.php on line 123

      Attachments

        Issue Links

          Activity

            People

              stevani.andolo@moodle.com Stevani Andolo
              meirza.arson@moodle.com Meirza
              Huong Nguyen Huong Nguyen
              Andrew Lyons Andrew Lyons
              Kim Jared Lucas Kim Jared Lucas
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 day, 1 hour, 24 minutes
                  1d 1h 24m

                  Clockify

                    Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.