Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-78597

Display course preconfigured LTI tools constantly in the activity chooser

    XMLWordPrintable

Details

    • MOODLE_403_STABLE
    • MOODLE_403_STABLE
    • MDL-78597-master
    • Hide

      Overview

      We're going to regression test the following tool instances:

      • Instance which uses a domain-matched hidden site tool
      • Instance which uses an explicitly set site tool
      • Instance with completely isolated manual configuration
      • Instance using an existing course tool

      We're also going to verify:

      • that a legacy course tool isn't automatically present in the activity chooser after upgrade
      • that a newly created tool IS automatically present in the activity chooser.
      • that manual instance configuration fields are not visible for tools not support content selection
      • that manual instance configuration fields are visible for tools supporting content selection (an existing behaviour)

      Setup

      1. We need to create 3 tool instances before upgrading, so we can test legacy data, so install a site using weekly:
        On a fresh site, not yet installed.

        git checkout 57ae65f514968ea4e5e66706179dbaf64ac27fcd
        

      2. Install the site
      3. Login as admin
      4. Go to Site admin > Plugins > Activity plugins > External tool > Manage tools
      5. Click "Configure a tool manually"
      6. Set the form fields as follows:
        • Tool name: "Site tool example dot com"
        • Tool URL: http://example.com
        • Tool configuration usage: Do not show; use only when a matching tool URL is entered
      7. Expand the Privacy fieldset
      8. Set the following:
        • Share launcher's name: Always
        • Share launcher's email: Never
        • Accept grades: Delegate
      9. Save the tool
      10. Click "Configure a tool manually"
      11. Set the form fields as follows:
        • Tool name: "Visible site tool"
        • Tool URL: https://something.com/
        • Tool configuration usage: "Show as a preconfigured tool when adding an external tool"
      12. Expand the Privacy fieldset
      13. Set the following:
        • Share launcher's name: Always
        • Share launcher's email: Always
        • Accept grades: Always
      14. Save the tool
      15. Create a course
      16. Enrol a teacher t1 in the course as 'editingteacher'
      17. In the course, click to add an activity or resource, selecting "External tool"
      18. Set the following form fields:
      19. Tab out of the tool URL field and wait a second or two until you see "Using tool configuration: Site tool example dot com"
      20. Expand the privacy fieldset
      21. Confirm that the first checkbox is checked and disabled
      22. Confirm that the second checkbox is unchecked and disabled
      23. Confirm that the third checkbox can be checked
      24. Check "Accept grades from the tool"
      25. Save and return to course
      26. Launch the activity and you should see it open example.com in an embedded view. That's all we need to do for now.
      27. In the course, click to add an activity or resource, selecting "External tool"
      28. Set the following form fields:
        • Activity name: "Legacy tool, explicit site tool"
        • Preconfigured tool: "Visible site tool"
      29. Expand the privacy fieldset
      30. Confirm that the first checkbox is checked and disabled
      31. Confirm that the second checkbox is checked and disabled
      32. Confirm that the third checkbox is checked and disabled
      33. Save and return to course
      34. Launch the activity and you should see it open something.com in an embedded view. That's all we need to do for now.
      35. In the course, click to add an activity or resource, selecting "External tool"
      36. Click 'Show more...'
      37. Set the form fields as follows:
        • Activity name: Legacy tool manual instance config
        • Activity description: My legacy tool description
        • Secure tool URL: <empty>
        • Launch container: Embed
        • Consumer key: jisc.ac.uk
        • Shared secret: secret
        • Custom params: test=cat
        • Icon URL: <enter some URL to an icon>
        • Secure icon URL: <empty>
        • Preconfigured tool: Automatic, based on tool URL
        • Tool URL: https://saltire.lti.app/tool
      38. Expand the 'privacy' fieldset
      39. Set the following:
        • Share launcher's name: Yes
        • Share launcher's email: No
        • Accept grades: No
      40. Save and return to course
      41. Launch the activity and you should see it open saltire test tool in an embedded view. That's all we need to do for now.
      42. Go to course home
      43. Click to add an activity or resource, selecting "External tool" when prompted
      44. Click the "+" icon next to the Preconfigured tool select
      45. In the form that opens, set the following:
      46. Click "Save changes". You should now see "Legacy course tool" selected in the "Preconfigured tool" select.
      47. Enter the activity name "Legacy course tool instance"
      48. Click "Save and return to course"
      49. Launch the activity and you should see it open neverssl in an embedded view. That's all we need to do for now.

      Upgrade

      1. Now checkout master (or apply the patch if you're testing this during peer review):

        git checkout master
        

      2. Upgrade the site. Note: you may see deprecation notices on the screen during upgrade, this is a known issue so just ignore it here.

      Testing domain-matched legacy tool instance

      1. Login as the teacher user, t1
      2. Go to the course
      3. Edit the settings for the activity "Legacy tool, site domain match"
      4. Click 'Show more...' and expand the 'Privacy' fieldset
      5. Verify the following:
        • You see a notice on the page, explaining that manually configured instances are no longer supported.
        • The activity name and description are editable
        • The 3 checkboxes below the activity description are editable
        • Everything from Secure tool URL through Tool URL in the first section of the form is locked and cannot be edited
        • You see "Automatic, based on tool URL" next to the "Preconfigured tool" fieldname
        • You see "Default" next to the "Launch container" field name
        • You can see the Tool URL value 'http://example.com'
        • You can see the 3 privacy checkboxes, however all 3 are disabled.
        • The values of the privacy checkboxes, respectively are: First checkbox: Checked, Second checkbox: Unchecked, Third checkbox: Checked.
      6. Change the activity name to "Legacy tool, site domain match EDITED"
      7. Click "Save and display"
      8. Verify you see http://example.com in an embedded view
      9. Verify the activity name now includes 'EDITED'
      10. Edit the settings again
      11. Verify:
        • Preconfigured tool is still listed as "Automatic, based on tool URL"
        • Tool URL is still listed as 'http://example.com'
      12. Go to course home
      13. Launch the activity "Legacy tool, site domain match EDITED" and Verify you see it open http://example.com in an embedded view.

      Testing legacy tool instance using explicitly set site tool

      1. Login as the teacher user, t1
      2. Go to the course
      3. Edit the settings for the activity "Legacy tool, explicit site tool"
      4. Click 'Show more...' and expand the 'Privacy' fieldset
      5. Verify the following:
        • You don't see any notice on the page
        • You see the "Launch container", "Custom parameters", "Preconfigured tool" fields
        • Preconfigured tool is set to "Visible site tool"
        • You don't see "Tool URL", "Consumer key" or "Shared secret" fields
      6. Go to course home
      7. Launch the activity "Legacy tool, explicit site tool" and Verify you see it open https://something.com in an embedded view.

      Testing manually configured legacy tool instance

      1. Go to the course home
      2. Edit the settings for the activity "Legacy tool manual instance config"
      3. Click 'Show more...' and expand the 'Privacy' fieldset
      4. Verify the following:
        • You see a notice on the page, explaining that manually configured instances are no longer supported.
        • The activity name and description are editable
        • The 3 checkboxes below the activity description are editable
        • Everything from Secure tool URL through Tool URL in the first section of the form is locked and cannot be edited
        • You see "Automatic, based on tool URL" next to the "Preconfigured tool" fieldname
        • You see "Embed" next to the "Launch container" field name
        • You can see the Tool URL value 'https://saltire.lti.app/tool' in the disabled field
        • You can see the 3 privacy checkboxes, however all 3 are disabled.
        • The values of the privacy checkboxes, respectively are: First checkbox: Checked, Second checkbox: Unchecked, Third checkbox: Unchecked.
        • You can view the information for all locked fields (you can show the password by clicking the icon next to that field)
      5. Edit the activity name, setting it to 'Legacy tool manual instance config EDITED'
      6. Click "Save and display"
      7. Verify:
        • You see the saltire app loaded in an embedded view
        • The activity name now contains EDITED
      8. Edit the activity settings again
      9. Verify:
        • Preconfigured tool is still listed as "Automatic, based on tool URL"
        • Tool URL is still listed as 'https://saltire.lti.app/tool'
      10. Go to course home
      11. Launch the activity "Legacy tool manual instance config EDITED" and Verify you see it open the Saltire app in an embedded view.

      Testing legacy tool instance using course tool

      1. Go to the course home
      2. Edit the settings of the activity "Legacy course tool instance"
      3. Click 'Show more...' and expand the 'Privacy' fieldset
      4. Verify:
        • You don't see a notice about manually configured instances
        • The 'Preconfigured tool' select has the selected value 'Legacy course tool'
        • The 'Preconfigured tool' select does NOT have an option 'Automatic, based on tool URL'
        • You do see fields "Consumer key", "Shared secret", "Tool URL"
        • None of the fields are locked
        • None of the privacy fields are locked
      5. Go back to course home
      6. Launch the activity and Verify you see it open neverssl in an embedded view.

      Testing mod/lti:addcoursetool permission logic

      1. Log in to the site as an admin
      2. Now, go to course participants, and enrol the user m1 as a 'Manager' role
      3. Go to "Permissions"
      4. Set "Advanced role override" to "Manager"
      5. Enter 'mod/lti' into the filter, to help see the mod/lti capabilities more easily.
      6. Set 'mod/lti:addcoursetool' to 'Prohibit'
      7. Save changes
      8. Log out
      9. Log in as the user m1
      10. Go to the course
      11. Edit the settings for the activity "Legacy tool, site domain match EDITED"
      12. Click 'Show more...'
      13. Verify:
        • You see a notice on the page, explaining that manually configured instances are no longer supported.
        • The activity name is editable
        • The activity description is editable
        • The 3 checkboxes below the activity description are editable
        • Launch container shows "Default" and is locked
        • Preconfigured tool shows "Automatic, based on tool URL" and is locked
        • Select content button is locked
        • You can't see fields "Consumer key" or "Shared secret"
        • All options under the Privacy section are locked.
      14. Go back to course home
      15. Launch the activity "Legacy tool, site domain match EDITED" and Verify you see it open http://example.com in an embedded view.
      16. Go back to course home
      17. Edit the settings for the activity "Legacy tool manual instance config EDITED"
      18. Click 'Show more...'
      19. Verify:
        • You see a notice on the page, explaining that manually configured instances are no longer supported.
        • The activity name is editable
        • The activity description is editable
        • The 3 checkboxes below the activity description are editable
        • Launch container shows "Embed" and is locked
        • You can't see "Tool URL" or "Preconfigured tool" fields
        • You can't see fields "Consumer key" or "Shared secret"
        • All options under the Privacy section are locked.
      20. Go to course home
      21. Launch the activity "Legacy tool manual instance config EDITED" and Verify you see it open the Saltire app in an embedded view.
      22. Go back to course home
      23. Edit the settings for the activity "Legacy course tool instance"
      24. Click 'Show more...' and expand the 'Privacy' fieldset
      25. Verify:
        • You don't see a notice about manually configured instances
        • The 'Preconfigured tool' select has the selected value 'Legacy course tool'
        • The 'Preconfigured tool' select does NOT have an option 'Automatic, based on tool URL'
        • You do NOT see fields "Consumer key", "Shared secret", "Tool URL"
        • None of the fields are locked
        • None of the privacy fields are locked
      26. Go back to course home
      27. Launch the activity and Verify you see it open neverssl in an embedded view.
      28. Log out

      Testing new course-level tools

      1. Log in as the teacher user, t1
      2. Go back to course home
      3. Click to add an activity or resource
      4. Verify:
        • You don't see "External tool" there any more
        • You don't see "Legacy course tool" there (we're not updating legacy tools' activity chooser display during upgrade)
      5. Close the activity chooser
      6. Go to More > LTI External tools
      7. Add new tool with the following information:
      8. Now go back to course home
      9. Click to add an activity or resource
      10. Verify you see "New course tool" listed in the activity chooser
      11. Click "New course tool"
      12. Enter the activity name "New course tool instance"
        Note: (If you click 'Show more...' on this add instance form it will reveal a bunch of manual instance config fields - this is an existing problem and will be resolved when we add the new instance add/edit form in a future issue)
      13. Click "Save and display"
      14. Verify you see http://example.net launched in an embedded view.
      15. Edit the settings of "New course tool instance"
      16. Click 'Show more...' and expand the 'Privacy' fieldset
      17. Verify:
        • You see the following fields in the first section of the form: "Activity name", "Activity description", 3 checkboxes (display ...), "Launch container", "Custom params" and "Preconfigured tool".
        • You don't see any other fields like Tool URL, Shared secret, etc.
        • The privacy options are editable

      Testing 'migration' of a locked manually-configured tool instance

      1. Go to the course home
      2. Go to "More > LTI External tools"
      3. Add a new tool
      4. Enter the following form field data:
      5. Save the tool
      6. Go back to course home
      7. Click to add an activity or resource
      8. Select "Course tool Saltire"
      9. Set the activity name "Course tool Saltire instance"
      10. Click "Save and display"
      11. Verify you see Saltire launch in an embedded view
      12. Go back to course home
      13. Edit the settings of the activity "Course tool Saltire instance"
      14. Click 'Show more...'
      15. Verify you see field "Tool URL", "Consumer key" and "Shared secret" (this confirms existing behaviour for tool instances for tools supporting content selection).
      16. Go back to course home
      17. Edit the settings of the activity "Legacy tool manual instance config EDITED"
      18. Verify:
        • You still see a notice about manual configuration being unsupported
        • All configuration fields (i.e. not the activity name, description and 3 checkboxes below description) are still locked

      Testing editing a course-level tool at site admin

      1. Login as the admin
      2. Go to "Plugins > Activity plugins > External tool > Manage tools"
      3. Edit the course-level tool "Course tool Saltire"
      4. Verify you don't see any "Tool configuration usage" form field. This cannot be set at site level any more for course tools.

      Testing manual instance form is blocked

      1. Visit the following URL in your site, replacing the SITE part and COURSEID part:

        http://SITE/course/modedit.php?add=lti&type&course=COURSEID&section=0&return=0&sr=0&beforemod=0
        

      2. Verify you see an error "The manual creation of tools without a course tool definition is no longer supported. Please create a course tool first and then use that to create activity instances."
      Show
      Overview We're going to regression test the following tool instances: Instance which uses a domain-matched hidden site tool Instance which uses an explicitly set site tool Instance with completely isolated manual configuration Instance using an existing course tool We're also going to verify: that a legacy course tool isn't automatically present in the activity chooser after upgrade that a newly created tool IS automatically present in the activity chooser. that manual instance configuration fields are not visible for tools not support content selection that manual instance configuration fields are visible for tools supporting content selection (an existing behaviour) Setup We need to create 3 tool instances before upgrading, so we can test legacy data, so install a site using weekly: On a fresh site, not yet installed. git checkout 57ae65f514968ea4e5e66706179dbaf64ac27fcd Install the site Login as admin Go to Site admin > Plugins > Activity plugins > External tool > Manage tools Click "Configure a tool manually" Set the form fields as follows: Tool name: "Site tool example dot com" Tool URL: http://example.com Tool configuration usage: Do not show; use only when a matching tool URL is entered Expand the Privacy fieldset Set the following: Share launcher's name: Always Share launcher's email: Never Accept grades: Delegate Save the tool Click "Configure a tool manually" Set the form fields as follows: Tool name: "Visible site tool" Tool URL: https://something.com/ Tool configuration usage: "Show as a preconfigured tool when adding an external tool" Expand the Privacy fieldset Set the following: Share launcher's name: Always Share launcher's email: Always Accept grades: Always Save the tool Create a course Enrol a teacher t1 in the course as 'editingteacher' In the course, click to add an activity or resource, selecting "External tool" Set the following form fields: Activity name: "Legacy tool, site domain match" Tool URL: http://example.com Tab out of the tool URL field and wait a second or two until you see "Using tool configuration: Site tool example dot com" Expand the privacy fieldset Confirm that the first checkbox is checked and disabled Confirm that the second checkbox is unchecked and disabled Confirm that the third checkbox can be checked Check "Accept grades from the tool" Save and return to course Launch the activity and you should see it open example.com in an embedded view. That's all we need to do for now. In the course, click to add an activity or resource, selecting "External tool" Set the following form fields: Activity name: "Legacy tool, explicit site tool" Preconfigured tool: "Visible site tool" Expand the privacy fieldset Confirm that the first checkbox is checked and disabled Confirm that the second checkbox is checked and disabled Confirm that the third checkbox is checked and disabled Save and return to course Launch the activity and you should see it open something.com in an embedded view. That's all we need to do for now. In the course, click to add an activity or resource, selecting "External tool" Click 'Show more...' Set the form fields as follows: Activity name: Legacy tool manual instance config Activity description: My legacy tool description Secure tool URL: <empty> Launch container: Embed Consumer key: jisc.ac.uk Shared secret: secret Custom params: test=cat Icon URL: <enter some URL to an icon> Secure icon URL: <empty> Preconfigured tool: Automatic, based on tool URL Tool URL: https://saltire.lti.app/tool Expand the 'privacy' fieldset Set the following: Share launcher's name: Yes Share launcher's email: No Accept grades: No Save and return to course Launch the activity and you should see it open saltire test tool in an embedded view. That's all we need to do for now. Go to course home Click to add an activity or resource, selecting "External tool" when prompted Click the "+" icon next to the Preconfigured tool select In the form that opens, set the following: Tool name: Legacy course tool Tool URL: http://neverssl.com 'Supports Deep linking': Yes/Checked Content selection URL: http://neverssl.com Click "Save changes". You should now see "Legacy course tool" selected in the "Preconfigured tool" select. Enter the activity name "Legacy course tool instance" Click "Save and return to course" Launch the activity and you should see it open neverssl in an embedded view. That's all we need to do for now. Upgrade Now checkout master (or apply the patch if you're testing this during peer review): git checkout master Upgrade the site. Note: you may see deprecation notices on the screen during upgrade, this is a known issue so just ignore it here. Testing domain-matched legacy tool instance Login as the teacher user, t1 Go to the course Edit the settings for the activity "Legacy tool, site domain match" Click 'Show more...' and expand the 'Privacy' fieldset Verify the following: You see a notice on the page, explaining that manually configured instances are no longer supported. The activity name and description are editable The 3 checkboxes below the activity description are editable Everything from Secure tool URL through Tool URL in the first section of the form is locked and cannot be edited You see "Automatic, based on tool URL" next to the "Preconfigured tool" fieldname You see "Default" next to the "Launch container" field name You can see the Tool URL value 'http://example.com' You can see the 3 privacy checkboxes, however all 3 are disabled. The values of the privacy checkboxes, respectively are: First checkbox: Checked, Second checkbox: Unchecked, Third checkbox: Checked. Change the activity name to "Legacy tool, site domain match EDITED" Click "Save and display" Verify you see http://example.com in an embedded view Verify the activity name now includes 'EDITED' Edit the settings again Verify : Preconfigured tool is still listed as "Automatic, based on tool URL" Tool URL is still listed as 'http://example.com' Go to course home Launch the activity "Legacy tool, site domain match EDITED" and Verify you see it open http://example.com in an embedded view. Testing legacy tool instance using explicitly set site tool Login as the teacher user, t1 Go to the course Edit the settings for the activity "Legacy tool, explicit site tool" Click 'Show more...' and expand the 'Privacy' fieldset Verify the following: You don't see any notice on the page You see the "Launch container", "Custom parameters", "Preconfigured tool" fields Preconfigured tool is set to "Visible site tool" You don't see "Tool URL", "Consumer key" or "Shared secret" fields Go to course home Launch the activity "Legacy tool, explicit site tool" and Verify you see it open https://something.com in an embedded view. Testing manually configured legacy tool instance Go to the course home Edit the settings for the activity "Legacy tool manual instance config" Click 'Show more...' and expand the 'Privacy' fieldset Verify the following: You see a notice on the page, explaining that manually configured instances are no longer supported. The activity name and description are editable The 3 checkboxes below the activity description are editable Everything from Secure tool URL through Tool URL in the first section of the form is locked and cannot be edited You see "Automatic, based on tool URL" next to the "Preconfigured tool" fieldname You see "Embed" next to the "Launch container" field name You can see the Tool URL value 'https://saltire.lti.app/tool' in the disabled field You can see the 3 privacy checkboxes, however all 3 are disabled. The values of the privacy checkboxes, respectively are: First checkbox: Checked, Second checkbox: Unchecked, Third checkbox: Unchecked. You can view the information for all locked fields (you can show the password by clicking the icon next to that field) Edit the activity name, setting it to 'Legacy tool manual instance config EDITED' Click "Save and display" Verify : You see the saltire app loaded in an embedded view The activity name now contains EDITED Edit the activity settings again Verify : Preconfigured tool is still listed as "Automatic, based on tool URL" Tool URL is still listed as 'https://saltire.lti.app/tool' Go to course home Launch the activity "Legacy tool manual instance config EDITED" and Verify you see it open the Saltire app in an embedded view. Testing legacy tool instance using course tool Go to the course home Edit the settings of the activity "Legacy course tool instance" Click 'Show more...' and expand the 'Privacy' fieldset Verify : You don't see a notice about manually configured instances The 'Preconfigured tool' select has the selected value 'Legacy course tool' The 'Preconfigured tool' select does NOT have an option 'Automatic, based on tool URL' You do see fields "Consumer key", "Shared secret", "Tool URL" None of the fields are locked None of the privacy fields are locked Go back to course home Launch the activity and Verify you see it open neverssl in an embedded view. Testing mod/lti:addcoursetool permission logic Log in to the site as an admin Now, go to course participants, and enrol the user m1 as a 'Manager' role Go to "Permissions" Set "Advanced role override" to "Manager" Enter 'mod/lti' into the filter, to help see the mod/lti capabilities more easily. Set 'mod/lti:addcoursetool' to 'Prohibit' Save changes Log out Log in as the user m1 Go to the course Edit the settings for the activity "Legacy tool, site domain match EDITED" Click 'Show more...' Verify : You see a notice on the page, explaining that manually configured instances are no longer supported. The activity name is editable The activity description is editable The 3 checkboxes below the activity description are editable Launch container shows "Default" and is locked Preconfigured tool shows "Automatic, based on tool URL" and is locked Select content button is locked You can't see fields "Consumer key" or "Shared secret" All options under the Privacy section are locked. Go back to course home Launch the activity "Legacy tool, site domain match EDITED" and Verify you see it open http://example.com in an embedded view. Go back to course home Edit the settings for the activity "Legacy tool manual instance config EDITED" Click 'Show more...' Verify : You see a notice on the page, explaining that manually configured instances are no longer supported. The activity name is editable The activity description is editable The 3 checkboxes below the activity description are editable Launch container shows "Embed" and is locked You can't see "Tool URL" or "Preconfigured tool" fields You can't see fields "Consumer key" or "Shared secret" All options under the Privacy section are locked. Go to course home Launch the activity "Legacy tool manual instance config EDITED" and Verify you see it open the Saltire app in an embedded view. Go back to course home Edit the settings for the activity "Legacy course tool instance" Click 'Show more...' and expand the 'Privacy' fieldset Verify : You don't see a notice about manually configured instances The 'Preconfigured tool' select has the selected value 'Legacy course tool' The 'Preconfigured tool' select does NOT have an option 'Automatic, based on tool URL' You do NOT see fields "Consumer key", "Shared secret", "Tool URL" None of the fields are locked None of the privacy fields are locked Go back to course home Launch the activity and Verify you see it open neverssl in an embedded view. Log out Testing new course-level tools Log in as the teacher user, t1 Go back to course home Click to add an activity or resource Verify : You don't see "External tool" there any more You don't see "Legacy course tool" there (we're not updating legacy tools' activity chooser display during upgrade) Close the activity chooser Go to More > LTI External tools Add new tool with the following information: Name: New course tool Tool URL: http://example.net Now go back to course home Click to add an activity or resource Verify you see "New course tool" listed in the activity chooser Click "New course tool" Enter the activity name "New course tool instance" Note: (If you click 'Show more...' on this add instance form it will reveal a bunch of manual instance config fields - this is an existing problem and will be resolved when we add the new instance add/edit form in a future issue) Click "Save and display" Verify you see http://example.net launched in an embedded view. Edit the settings of "New course tool instance" Click 'Show more...' and expand the 'Privacy' fieldset Verify : You see the following fields in the first section of the form: "Activity name", "Activity description", 3 checkboxes (display ...), "Launch container", "Custom params" and "Preconfigured tool". You don't see any other fields like Tool URL, Shared secret, etc. The privacy options are editable Testing 'migration' of a locked manually-configured tool instance Go to the course home Go to "More > LTI External tools" Add a new tool Enter the following form field data: Tool name: "Course tool Saltire" Tool URL: https://saltire.lti.app/tool Consumer key: jisc.ac.uk Shared secret: secret Supports deep linking: Yes (checked) Content selection URL: https://saltire.lti.app/tool Save the tool Go back to course home Click to add an activity or resource Select "Course tool Saltire" Set the activity name "Course tool Saltire instance" Click "Save and display" Verify you see Saltire launch in an embedded view Go back to course home Edit the settings of the activity "Course tool Saltire instance" Click 'Show more...' Verify you see field "Tool URL", "Consumer key" and "Shared secret" (this confirms existing behaviour for tool instances for tools supporting content selection). Go back to course home Edit the settings of the activity "Legacy tool manual instance config EDITED" Verify : You still see a notice about manual configuration being unsupported All configuration fields (i.e. not the activity name, description and 3 checkboxes below description) are still locked Testing editing a course-level tool at site admin Login as the admin Go to "Plugins > Activity plugins > External tool > Manage tools" Edit the course-level tool "Course tool Saltire" Verify you don't see any "Tool configuration usage" form field. This cannot be set at site level any more for course tools. Testing manual instance form is blocked Visit the following URL in your site, replacing the SITE part and COURSEID part: http://SITE/course/modedit.php?add=lti&type&course=COURSEID&section=0&return=0&sr=0&beforemod=0 Verify you see an error "The manual creation of tools without a course tool definition is no longer supported. Please create a course tool first and then use that to create activity instances."
    • 3
    • Team Alpha - Planning I3-2023, Team Alpha - Sprint 1 I3-2023

    Description

      Summary:

      One of the aims of the planned improvements related to the configuration and usage of  course configured LTI tools is to decouple the tool configuration from the creation of course activities. Once the configuration is done elsewhere teachers should be able to easily use the LTI tools to create activities in the course using the activity chooser.

      Course configured LTI tools can be displayed in the activity chooser at the moment, but not by default and this cannot be configured by teachers as it needs to be set in the system level through the 'Manage tools' page in site administration.

      This is a limitation for teachers and significant roadblock towards the goal of decoupling the configuration of LTI tools and creating course activities. Therefore the aim of this issue it to force course configured LTI tools to be constantly displayed in the activity chooser as a default and non-configurable behaviour. The present setting will be only applied to LTI tools configured in the system level.

      Scope:

      1. Configured LTI external tools in the course are always displayed within the activity chooser in the course by default.
      2. Remove the 'Tool configuration usage' option from the configuration settings for course LTI external tools (should always default to 'Show in activity chooser and as preconfigured tool' upon tool creation) - note this is when a site admin is editing a course tool via site admin, where that option exists in the form.
      3. Remove the 'External tool' activity from the activity chooser.
      4. Automated testing.

      Attachments

        1. (I) 11 Passed -- (Master)MDL-78597.png
          28 kB
          Kim Jared Lucas
        2. (I) 13 Passed -- (Master)MDL-78597.png
          68 kB
          Kim Jared Lucas
        3. (I) 5 Passed -- (Master)MDL-78597.png
          87 kB
          Kim Jared Lucas
        4. (I) 8-9 Passed -- (Master)MDL-78597.png
          105 kB
          Kim Jared Lucas
        5. (II) 5 Passed -- (Master)MDL-78597.png
          80 kB
          Kim Jared Lucas
        6. (II) 7 Passed -- (Master)MDL-78597.png
          49 kB
          Kim Jared Lucas
        7. (III) 11 Passed -- (Master)MDL-78597.png
          115 kB
          Kim Jared Lucas
        8. (III) 4 Passed -- (Master)MDL-78597.png
          84 kB
          Kim Jared Lucas
        9. (III) 7 Passed -- (Master)MDL-78597.png
          89 kB
          Kim Jared Lucas
        10. (III) 9 Passed -- (Master)MDL-78597.png
          84 kB
          Kim Jared Lucas
        11. (IV) 4 Passed -- (Master)MDL-78597.png
          79 kB
          Kim Jared Lucas
        12. (IV) 6 Passed -- (Master)MDL-78597.png
          80 kB
          Kim Jared Lucas
        13. (IX) 2 Passed -- (Master)MDL-78597.png
          58 kB
          Kim Jared Lucas
        14. (V) 13 Passed -- (Master)MDL-78597.png
          98 kB
          Kim Jared Lucas
        15. (V) 15 Passed -- (Master)MDL-78597.png
          70 kB
          Kim Jared Lucas
        16. (V) 19 Passed -- (Master)MDL-78597.png
          81 kB
          Kim Jared Lucas
        17. (V) 21 Passed -- (Master)MDL-78597.png
          84 kB
          Kim Jared Lucas
        18. (V) 25 Passed -- (Master)MDL-78597.png
          85 kB
          Kim Jared Lucas
        19. (V) 27 Passed -- (Master)MDL-78597.png
          67 kB
          Kim Jared Lucas
        20. (VI) 10 Passed -- (Master)MDL-78597.png
          75 kB
          Kim Jared Lucas
        21. (VI) 14 Passed -- (Master)MDL-78597.png
          63 kB
          Kim Jared Lucas
        22. (VI) 17 Passed -- (Master)MDL-78597.png
          78 kB
          Kim Jared Lucas
        23. (VI) 4 Passed -- (Master)MDL-78597.png
          75 kB
          Kim Jared Lucas
        24. (VII) 11 Passed -- (Master)MDL-78597.png
          90 kB
          Kim Jared Lucas
        25. (VII) 15 Passed -- (Master)MDL-78597.png
          83 kB
          Kim Jared Lucas
        26. (VII) 18 Passed -- (Master)MDL-78597.png
          81 kB
          Kim Jared Lucas
        27. (VIII) 4 Passed -- (Master)MDL-78597.png
          57 kB
          Kim Jared Lucas
        28. testing1.png
          5.02 MB
          Mathew May
        29. testing2.png
          5.04 MB
          Mathew May
        30. testingwarning.png
          1.50 MB
          Mathew May

        Issue Links

          Activity

            People

              jaked Jake Dallimore
              Geshoski Mihail Geshoski
              Mathew May Mathew May
              Ilya Tregubov Ilya Tregubov
              Kim Jared Lucas Kim Jared Lucas
              Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 2 weeks, 3 hours, 19 minutes
                  2w 3h 19m

                  Clockify

                    Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.