Loading...

XML

Word

Printable

Type: Task
Resolution: Fixed
Priority: Minor
Fix Version/s: 5.0
Affects Version/s: 4.3
Component/s: IMS-CP resource type, LTI External tool
Labels:
- ci
- triaged

Affected Branches:
MOODLE_403_STABLE
Fixed Branches:
MOODLE_500_STABLE
Epic Link:
5.0 deprecations
Pull from Repository:
https://github.com/paulholden/moodle.git
Pull Main Branch:
~~MDL-78635~~
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...paulholden:MDL-78635
Testing Instructions:
Hide

Execute the following:

$ git grep -A1 -B2 "$imscp\|lti$_libxml_disable_entity_loader"

Confirm the only matches are the original methods (which emit final deprecation notice) and upgrade notes regarding removal
Show
Execute the following: $ git grep -A1 -B2 "$imscp\|lti$_libxml_disable_entity_loader" Confirm the only matches are the original methods (which emit final deprecation notice) and upgrade notes regarding removal
Pre-check results:
Hide

Fails against automated checks.

Checked ~~MDL-78635~~ using repository: https://github.com/paulholden/moodle.git

main [branch: MDL-78635 | CI Job]

Error: The ~~MDL-78635~~ branch at https://github.com/paulholden/moodle.git is very old (>60 days ago). Please rebase against current main.

Should these errors be fixed?

Built on: Tue Mar 4 07:08:38 UTC 2025
Show
Fails against automated checks. Checked MDL-78635 using repository: https://github.com/paulholden/moodle.git main [branch: MDL-78635 | CI Job ] Error: The MDL-78635 branch at https://github.com/paulholden/moodle.git is very old (>60 days ago). Please rebase against current main. Should these errors be fixed? Built on: Tue Mar 4 07:08:38 UTC 2025
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-78635~~

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18019/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61562/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61564/ Behat (Firefox - boost)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61566/ Behat (Firefox - classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61567/ App tests (stable app version) --> unrelated app failures

Built on: Wed Jan 22 06:55:55 AM UTC 2025
Show
Launching automatic jobs for branch MDL-78635 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18019/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61562/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61564/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61566/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61567/ App tests (stable app version) --> unrelated app failures Built on: Wed Jan 22 06:55:55 AM UTC 2025

See ~~MDL-76953~~ - final deprecation required for the following methods:

imscp_libxml_disable_entity_loader
lti_libxml_disable_entity_loader

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

MDL-78635_test.png
201 kB
12/Mar/25 7:29 PM

has to be done after

MDL-76953 Remove uses of libxml_disable_entity_loader in master

Closed

Assignee:: Paul Holden

Reporter:: Paul Holden

Peer reviewer:: Andrew Lyons

Integrator:: Sara Arjona (@sarjona)

Tester:: Sara Arjona (@sarjona)

Participants:: Andrew Lyons, CiBoT, Paul Holden, Sara Arjona (@sarjona)

Votes:: 0 Vote for this issue

Watchers:: 4 Start watching this issue

Created:: 03/Jul/23 7:31 PM

Updated:: Yesterday 11:32 PM

Resolved:: Yesterday 11:32 PM

Details

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Clockify