Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-78650

Assignment is still in timeline after submission with group submission, require to click submit, and no activity completion options

XMLWordPrintable

    • MOODLE_402_STABLE
    • MOODLE_401_STABLE, MOODLE_402_STABLE, MOODLE_403_STABLE
    • mdl-78650-401-stable
    • mdl-78650-403-stable
    • mdl-78650-master-alt-fix
    • Hide

      Covered by behat and PHPUnit tests.

       

       

      For manual test:

      Prerequisites:

      1. Create a course.
      2. Create two students (student1 and student2).
      3. Create a group and add the two students.
      4. Create a new assignment with the following settings (other settings default):
      5. Submission settings > Require students to click the submit button: Yes
      6. Group submission settings > Students submit in groups: Yes
      7. Activity completion > Completion tracking: Do not indicate activity completion

      Testing:

      1. Verify the assignment shows up in the timeline for both students.
      2. As student1, submit the assignment and confirm submission.
      3. Verify the assignment is gone from the timeline for both students.
      Show
      Covered by behat and PHPUnit tests.     For manual test: Prerequisites: Create a course. Create two students (student1 and student2). Create a group and add the two students. Create a new assignment with the following settings (other settings default): Submission settings > Require students to click the submit button: Yes Group submission settings > Students submit in groups: Yes Activity completion > Completion tracking: Do not indicate activity completion Testing: Verify the assignment shows up in the timeline for both students. As student1, submit the assignment and confirm submission. Verify the assignment is gone from the timeline for both students.

      There is an issue to showing the activity in the timeline block.
      When an assignment activity is set some particular settings, activity remains in the timeline and show overdue if the activity is after due date.

      How to replicate:
      1. Create a course.
      2. Create a group and enrol 2 students ("Student 1" and "Student 2").
      3. Create an assignment activity with following options.
       - Set "Yes" to "Require students to click the submit button" in "Submission settings"
       - Set "Yes" to "Students submit in groups" in "Group submission settings"
       - Set "Do not indicate activity completion" to "Completion tracking" in "Activity completion"
      4. Login as "Student 1". Go to dashboard and confirm the assignment in the timeline.
      5. Click "Add submission" in the timeline.
      6. Upload a file, "Save changes", "Submit assignment", and "Continue" to confirm submission.
      7. Back to the dashboard. Confirm the assignment activity is not in the timeline.
      8. Login as "Student 2". Go to dashboard and the assignment is in the timeline even other group member submitted the assignment.

      I debugged the issue, and found some logics to show the timeline records.

      If the activity is completed (has record in mdl_course_modules_completion table), then the activity is not shown.
      If the activity is not completed (includes off for "Completion tracking"), check assign_submission records.
      If the status of assign_submission is "submitted", then the activity is not shown (means completed).

      The issue is when the assignment submits by group and also has "Require students to click the submit button", then the submission of other member of the group doesn't change to "submitted".

            avdb Alexander Van der Bellen
            tomotsuyuki Tomo Tsuyuki
            cameron1729 cameron1729
            Sara Arjona (@sarjona) Sara Arjona (@sarjona)
            CiBoT CiBoT
            Votes:
            0 Vote for this issue
            Watchers:
            17 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour, 15 minutes
                1h 15m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.