Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-78678

Scrolling up and down a course page does not highlight modules with FEATURE_NO_VIEW_LINK (eg label) in the course index

XMLWordPrintable

    • MOODLE_403_STABLE
    • MOODLE_402_STABLE
    • MDL-78678-master
    • Hide
      • Create a 'Topics' format course with multiple sections and activities, and multiple 'Text and media' elements between activities.
      • Enrol a teacher and a student in the course.
      • Test using Boost theme only.

      Test

      1. Log in as student and navigate to the course.
      2. Open course index in case it is closed.
      3. Scroll the course content
        • Confirm the course index has the element that appears on top of the content as current (has a darker text and a darker background)
      4. Continue scrolling until the end of the course
        • Confirm the course index scrolls constantly to have the current element visible
      5. Confirm also 'Text and media' elements are highlighted as current.
      6. Log out as student and log in as teacher with edit mode disabled.
      7. Repeat steps from 2 to 5.
      8. Switch edit mode on.
      9. Repeat steps from 3 to 5.
      Show
      Create a 'Topics' format course with multiple sections and activities, and multiple 'Text and media' elements between activities. Enrol a teacher and a student in the course. Test using Boost theme only. Test Log in as student and navigate to the course. Open course index in case it is closed. Scroll the course content Confirm  the course index has the element that appears on top of the content as current (has a darker text and a darker background) Continue scrolling until the end of the course Confirm  the course index scrolls constantly to have the current element visible Confirm also 'Text and media' elements are highlighted as current. Log out as student and log in as teacher with edit mode disabled. Repeat steps from 2 to 5. Switch edit mode on. Repeat steps from 3 to 5.
    • 1
    • HQ 2023 Planning I3 Moppies

      If you are in non editing mode and scroll up and down a course the left course index updated to show which activity you have at the top of the scroll view port.

      But this doesn't work correctly when dealing with a mod_label instance and I believe this affects all 'resources' (eg discovered this with a custom resource plugin). Note that it does work correctly when in editing mode.

      See how in the gif below the 'Text and media area' gets skipped over:

        1. image-2023-07-08-14-55-26-447.png
          2.07 MB
          Brendan Heywood
        2. image-2023-08-03-22-17-50-024.png
          267 kB
          Brendan Heywood
        3. labels_click_position.mp4
          953 kB
          Amaia Anabitarte
        4. MDL-78678.png
          681 kB
          Ron Carl Alfon Yu

            amaia Amaia Anabitarte
            brendanheywood Brendan Heywood
            Brendan Heywood Brendan Heywood
            Ferran Recio Ferran Recio
            Ron Carl Alfon Yu Ron Carl Alfon Yu
            Votes:
            1 Vote for this issue
            Watchers:
            8 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 3 hours, 29 minutes
                3h 29m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.