Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Minor
Fix Version/s: 4.1.6, 4.2.3
Affects Version/s: 4.0.10, 4.1.5, 4.2.2
Component/s: Administration
Labels:
- ci
- release_notes
- triaged

Affected Branches:
MOODLE_400_STABLE, MOODLE_401_STABLE, MOODLE_402_STABLE
Fixed Branches:
MOODLE_401_STABLE, MOODLE_402_STABLE
Pull from Repository:
https://github.com/paulholden/moodle.git
Pull 4.1 Branch:
~~MDL-78688~~-401
Pull 4.1 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_401_STABLE...paulholden:MDL-78688-401
Pull 4.2 Branch:
~~MDL-78688~~-402
Pull 4.2 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_402_STABLE...paulholden:MDL-78688-402
Pull Main Branch:
~~MDL-78688~~
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/master...paulholden:MDL-78688
Testing Instructions:
Hide

Log in as admin

Navigate to Site admin presets in site administration

Press Import preset

Confirm you see the following:

Accepted file types:

application/xml .xml

Try to upload a non-XML file

Confirm the form warns you about invalid file type
Show
Log in as admin Navigate to Site admin presets in site administration Press Import preset Confirm you see the following: Accepted file types: application/xml .xml Try to upload a non-XML file Confirm the form warns you about invalid file type

Look at the form for uploading a preset to the file type:

Try to guess it's type, fail and receive very ugly error:

Warning: simplexml_load_string(): Entity: line 1: parser error : Start tag expected, '<' not found in /opt/moodle/master/src/admin/presets/classes/manager.php on line 628

Warning: simplexml_load_string(): Oops in /opt/moodle/master/src/admin/presets/classes/manager.php on line 628

Warning: simplexml_load_string(): ^ in /opt/moodle/master/src/admin/presets/classes/manager.php on line 628

Skip to main content

Wrong file

(Continue)

Error output, so disabling automatic redirect.

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

(I) 5 Passed -- (Master)MDL-78688.png
55 kB
25/Aug/23 11:08 AM
(I) 6 Passed -- (Master)MDL-78688.png
82 kB
25/Aug/23 11:08 AM
Screenshot 2023-07-10 at 16-09-12 Site admin presets.png
51 kB
10/Jul/23 11:15 PM
Screenshot 2023-07-10 at 16-09-39 This page should automatically redirect. If nothing is happening please use the continue link below.png
48 kB
10/Jul/23 11:15 PM

Discovered while testing

MDL-69187 Filepicker: file type validation behaves inconsistently depending on how the list of accepted types is passed

Closed

Assignee:: Paul Holden

Reporter:: Paul Holden

Peer reviewer:: Andrew Lyons

Integrator:: Sara Arjona (@sarjona)

Tester:: Kim Jared Lucas

Participants:: Andrew Lyons, CiBoT, Kim Jared Lucas, Paul Holden, Sara Arjona (@sarjona)

Votes:: 0 Vote for this issue

Watchers:: 3 Start watching this issue

Created:: 10/Jul/23 11:12 PM

Updated:: 06/Oct/23 10:25 PM

Resolved:: 26/Aug/23 12:27 PM

Estimated:

Remaining:

Logged:

25m

Details

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify