Loading...

XML

Word

Printable

Affected Branches:
MOODLE_401_STABLE
Fixed Branches:
MOODLE_403_STABLE
Pull from Repository:
https://github.com/mattporritt/moodle
Pull Main Branch:
master_~~MDL-78698~~
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/master...mattporritt:moodle:master_MDL-78698
Testing Instructions:
Hide

The deprecated method isn't used directly but is used by several other methods around Moodle LMS.
The easiest way to test that things are working from the UI is to:

Log into the site with a user that has permissions to create a course and perform user backups and restores (Admin is fine).

Create a course with a couple of activities

Backup the course

Confirm there were no errors during the backup

restore the course as a new isntance

confirm the course restored successfully.

Apart from the above make sure unit and behat tests pass.
Show
The deprecated method isn't used directly but is used by several other methods around Moodle LMS. The easiest way to test that things are working from the UI is to: Log into the site with a user that has permissions to create a course and perform user backups and restores (Admin is fine). Create a course with a couple of activities Backup the course Confirm there were no errors during the backup restore the course as a new isntance confirm the course restored successfully. Apart from the above make sure unit and behat tests pass.

The function random_bytes_emulate (https://github.com/moodle/moodle/blob/master/lib/moodlelib.php#L8496) tries to generate cryptographically secure pseudo-random bytes.

It does this by progressively falling back to alternate (worse) methods of generating random bytes.

The first method it tries is the native PHP7 random_bytes method which does generate cryptographically secure random bytes (https://www.php.net/manual/en/function.random-bytes.php).

Now that all supported versions of Moodle support at least PHP 7 (for a while).

We should now deprecate (https://moodledev.io/general/development/policies/deprecation) random_bytes_emulate and just use random_bytes.

This means:

has a non-specific relationship to

MDL-67390 Update password hashing to SHA-512

Participants:: CiBoT, Ilya Tregubov, Matt Porritt, Paul Holden, Ron Carl Alfon Yu

Estimated:

Remaining:

Logged:

3h 29m