Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-78707

Change from expand all to collapse all when all fieldsets are expanded

    XMLWordPrintable

Details

    • MOODLE_403_STABLE
    • MOODLE_401_STABLE, MOODLE_402_STABLE
    • MDL-78707-401
    • MDL-78707-402
    • Hide
      1. Login as admin
      2. Create a course
      3. Turn editing on
      4. Open Add an activity or resource modal
      5. Select File
      6. Manually expand each form section (General, Appearance, Common module settings, etc.) separately
      7. After the last section is expanded confirm the Expand all link has changed to Collapse all
      8. Manually collapse each form section separately
      9. After the last section is collapsed confirm the Collapse all link has changed to Expand all
      10. Press Expand all
      11. Confirm all sections are expanded
      12. Press Collapse all
      13. Confirm all sections are collapsed
      14. Manually expand the Restrict access section
      15. Confirm the Access restrictions text is shown, along with None and Add restriction.. button (MDL-78581)
      Show
      Login as admin Create a course Turn editing on Open Add an activity or resource modal Select File Manually expand each form section (General, Appearance, Common module settings, etc.) separately After the last section is expanded confirm the Expand all link has changed to Collapse all Manually collapse each form section separately After the last section is collapsed confirm the Collapse all link has changed to Expand all Press Expand all Confirm all sections are expanded Press Collapse all Confirm all sections are collapsed Manually expand the Restrict access section Confirm the Access restrictions text is shown, along with None and Add restriction.. button ( MDL-78581 )

    Description

      When expanding all headsets manually on activity settings form the 'Expand all' doesn't change to 'Collapse all' because /lib/form/amd/src/collapsesections.js is counting all the fcontainer and not fieldsets only, and access restrictions form is using fcontainer class too.

      Steps to reproduce:

      As a teacher create an activity that allows adding access restrictions.

      Manually expand all visible field sections

      Confirm there is a 'Expand all' at the top of the form. It should change to 'Collapse all'

      Attachments

        Issue Links

          Activity

            People

              pholden Paul Holden
              amaia Amaia Anabitarte
              Andrew Lyons Andrew Lyons
              Sara Arjona (@sarjona) Sara Arjona (@sarjona)
              Ron Carl Alfon Yu Ron Carl Alfon Yu
              Votes:
              1 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 hour, 33 minutes
                  1h 33m

                  Clockify

                    Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.