Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Minor
Fix Version/s: 4.1.6, 4.2.3
Affects Version/s: 4.1.4
Component/s: Forms Library
Labels:

Affected Branches:
MOODLE_401_STABLE
Fixed Branches:
MOODLE_401_STABLE, MOODLE_402_STABLE
Pull from Repository:
https://github.com/paulholden/moodle/
Pull 4.1 Branch:
~~MDL-78728~~-401
Pull 4.1 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_401_STABLE...paulholden:MDL-78728-401
Pull Main Branch:
~~MDL-78728~~
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/master...paulholden:MDL-78728
Testing Instructions:
Hide

Regression test only (read-only forms are covered by Behat)

Login as admin

Create a course

Turn editing on

Open Add an activity or resource modal

Select File

Manually expand each form section (General, Appearance, Common module settings, etc.) separately

After the last section is expanded confirm the Expand all link has changed to Collapse all

Manually collapse each form section separately

After the last section is collapsed confirm the Collapse all link has changed to Expand all

Press Expand all

Confirm all sections are expanded

Press Collapse all

Confirm all sections are collapsed

Manually expand the Restrict access section

Confirm the Access restrictions text is shown, along with None and Add restriction.. button
Show
Regression test only (read-only forms are covered by Behat) Login as admin Create a course Turn editing on Open Add an activity or resource modal Select File Manually expand each form section (General, Appearance, Common module settings, etc.) separately After the last section is expanded confirm the Expand all link has changed to Collapse all Manually collapse each form section separately After the last section is collapsed confirm the Collapse all link has changed to Expand all Press Expand all Confirm all sections are expanded Press Collapse all Confirm all sections are collapsed Manually expand the Restrict access section Confirm the Access restrictions text is shown, along with None and Add restriction.. button

Discovered while looking at ~~MDL-78707~~ - when toggling the sections in the test fixture, you receive the following errors on browser console

09:19:12.820 Uncaught TypeError: formParent is null

    init http://moodle.internal/master/lib/requirejs.php/1689581882/core_form/events.js:1870

    jQuery 7

    show http://moodle.internal/master/lib/requirejs.php/1689581882/core_form/events.js:4583

    i jQuery

    handle http://moodle.internal/master/lib/requirejs.php/1689581882/core_form/events.js:4591

    jQuery 7

    triggerTransitionEnd http://moodle.internal/master/lib/requirejs.php/1689581882/core_form/events.js:4591

    transitionEndEmulator http://moodle.internal/master/lib/requirejs.php/1689581882/core_form/events.js:4591

    setTimeout handler*transitionEndEmulator http://moodle.internal/master/lib/requirejs.php/1689581882/core_form/events.js:4591

    show http://moodle.internal/master/lib/requirejs.php/1689581882/core_form/events.js:4583

    toggle http://moodle.internal/master/lib/requirejs.php/1689581882/core_form/events.js:4583

    Collapse http://moodle.internal/master/lib/requirejs.php/1689581882/core_form/events.js:4583

    _jQueryInterface http://moodle.internal/master/lib/requirejs.php/1689581882/core_form/events.js:4583

    jQuery 2

    _jQueryInterface http://moodle.internal/master/lib/requirejs.php/1689581882/core_form/events.js:4583

    <anonymous> http://moodle.internal/master/lib/requirejs.php/1689581882/core_form/events.js:4583

    jQuery 2

    <anonymous> http://moodle.internal/master/lib/requirejs.php/1689581882/core_form/events.js:4583

    jQuery 8

    <anonymous> http://moodle.internal/master/lib/requirejs.php/1689581882/core_form/events.js:4589

    execCb http://moodle.internal/master/lib/javascript.php/1689581882/lib/requirejs/require.min.js:5

    check http://moodle.internal/master/lib/javascript.php/1689581882/lib/requirejs/require.min.js:5

    enable http://moodle.internal/master/lib/javascript.php/1689581882/lib/requirejs/require.min.js:5

    enable http://moodle.internal/master/lib/javascript.php/1689581882/lib/requirejs/require.min.js:5

    enable http://moodle.internal/master/lib/javascript.php/1689581882/lib/requirejs/require.min.js:5

    bind http://moodle.internal/master/lib/javascript.php/1689581882/lib/requirejs/require.min.js:5

    each http://moodle.internal/master/lib/javascript.php/1689581882/lib/requirejs/require.min.js:5

    enable http://moodle.internal/master/lib/javascript.php/1689581882/lib/requirejs/require.min.js:5

    enable http://moodle.internal/master/lib/javascript.php/1689581882/lib/requirejs/require.min.js:5

    enable http://moodle.internal/master/lib/javascript.php/1689581882/lib/requirejs/require.min.js:5

    bind http://moodle.internal/master/lib/javascript.php/1689581882/lib/requirejs/require.min.js:5

    each http://moodle.internal/master/lib/javascript.php/1689581882/lib/requirejs/require.min.js:5

    enable http://moodle.internal/master/lib/javascript.php/1689581882/lib/requirejs/require.min.js:5

    init http://moodle.internal/master/lib/javascript.php/1689581882/lib/requirejs/require.min.js:5

    h http://moodle.internal/master/lib/javascript.php/1689581882/lib/requirejs/require.min.js:5

    completeLoad http://moodle.internal/master/lib/javascript.php/1689581882/lib/requirejs/require.min.js:5

    onScriptLoad http://moodle.internal/master/lib/javascript.php/1689581882/lib/requirejs/require.min.js:5

    load http://moodle.internal/master/lib/javascript.php/1689581882/lib/requirejs/require.min.js:5

    load http://moodle.internal/master/lib/javascript.php/1689581882/lib/requirejs/require.min.js:5

    load http://moodle.internal/master/lib/javascript.php/1689581882/lib/requirejs/require.min.js:5

    fetch http://moodle.internal/master/lib/javascript.php/1689581882/lib/requirejs/require.min.js:5

    check http://moodle.internal/master/lib/javascript.php/1689581882/lib/requirejs/require.min.js:5

    enable http://moodle.internal/master/lib/javascript.php/1689581882/lib/requirejs/require.min.js:5

events.js:1870:2195

To recreate manually navigate to <WWWROOT>/lib/tests/fixtures/readonlyform.php

Pressing Expand all generates the same error and doesn't have any effect on the page (nothing is expanded). Looks to be a regression from ~~MDL-75784~~, which assumes all the containers have a <form> ancestor

This will be partly resolved by ~~MDL-78707~~, there's just the expand/collapse all to fix here

P.S. Make sure that the Behat scenario is updated along with this issue, despite the errors reported here it currently still passes (it shouldn't). The updated scenario should fail on current master, but pass when this issue is fixed

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

MDL-78728.png
703 kB
15/Sep/23 1:02 PM

is a regression caused by

MDL-75784 Expand all/Collapse all button is not working when we have two more button in a page

Closed

is blocked by

MDL-78707 Change from expand all to collapse all when all fieldsets are expanded

Closed

Assignee:: Paul Holden

Reporter:: Paul Holden

Peer reviewer:: Mohamed Shehata

Integrator:: Huong Nguyen

Tester:: Ron Carl Alfon Yu

Participants:: CiBoT, Huong Nguyen, Mohamed Shehata, Paul Holden, Ron Carl Alfon Yu, ToBiC

Votes:: 0 Vote for this issue

Watchers:: 5 Start watching this issue

Created:: 17/Jul/23 4:24 PM

Updated:: 06/Oct/23 10:25 PM

Resolved:: 16/Sep/23 1:22 AM

Estimated:

Not Specified

Remaining:

Logged:

2h 30m

Details

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify