Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-78744

Refactor 'activity_information' output class

XMLWordPrintable

    • MOODLE_402_STABLE
    • MOODLE_403_STABLE
    • MDL-78744-master
    • Hide

      Main functionality is covered by behat tests except changes in content_notification_task

      Setup

      1. Login as administrator
      2. Purge all caches (this is needed if this is not a new site)
      3. Create a new user User1
      4. Create a new course Course1 and enrol User1 as a student
      5. Create a new assignment Assignment1 in Course1
        1. Set "Due date" to any date in the future

      Test (content_notification_task has no regression)

      1. Edit Assignment1 settings
      2. Modify completion tracking setting
      3. Mark "Send content change notification" as "checked"
      4. Save changes
      5. Run cron
      6. Login as User1
      7. Confirm that User1 has received a notification about the assignment
      8. Click on "View full notification"
      9. Confirm that the notification contains the "Due date" of the assignment
      Show
      Main functionality is covered by behat tests except changes in content_notification_task Setup Login as administrator Purge all caches (this is needed if this is not a new site) Create a new user User1 Create a new course Course1 and enrol User1 as a student Create a new assignment Assignment1 in Course1 Set "Due date" to any date in the future Test (content_notification_task has no regression) Edit Assignment1 settings Modify completion tracking setting Mark "Send content change notification" as "checked" Save changes Run cron Login as User1 Confirm that User1 has received a notification about the assignment Click on "View full notification" Confirm that the notification contains the "Due date" of the assignment
    • 3
    • HQ 2023 Sprint I3.1 Moppies

      The output class course/classes/output/activity_information handles both activity completion and activity dates together.
      It should be deprecated and split into two different output classes (activity_completion and activity_dates) so each of them will be responsible for its own data.

      By doing this we could avoid some cases like core_course\task\content_notification_task where activity_information is created, but only activity dates are needed.

      It is referenced in:

      • core_course\taskcontent_notification_task
      • core_course_renderer (Deprecation needed too)
      • core_courseformat\output\local\content\cm
      • renderer_base (Probably deprecation needed, as it is only used in mod_wiki_renderer::wiki_info() that is a deprecated function)

        1. image-2023-08-22-12-18-38-870.png
          image-2023-08-22-12-18-38-870.png
          24 kB
        2. MDL-78744.png
          MDL-78744.png
          434 kB

            mikelmartíncorrales Mikel Martín Corrales
            mikelmartíncorrales Mikel Martín Corrales
            Laurent David Laurent David
            Ilya Tregubov Ilya Tregubov
            Ron Carl Alfon Yu Ron Carl Alfon Yu
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 day, 4 hours, 59 minutes
                1d 4h 59m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.