Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-78746

addHelpButton() function doesn't allow to pass parameters to get_string

XMLWordPrintable

    • MOODLE_402_STABLE
    • MOODLE_403_STABLE
    • MDL-78746-master
    • Hide
      1. As an admin create a course with Completion tracking > Enable completion tracking = Yes
      2. Create an Assignment.
      3. Expand "Activity completion" settings in the assignment settings page
      4. Set Completion tracking to 'Students can manually mark the activity as completed' the setting has a different value.
      5. Confirm there is a 'Set reminder in Timeline' setting in 'Activity completion' settings group.
      6. Click '?' icon next to 'Set reminder in Timeline' setting and confirm the text is 'This allows you to set a reminder for students to work on this activity. It will appear on the Timeline block in their Dashboard as "Assignment requires action"'
      7. Create an Database activity.
      8. Expand "Activity completion" settings in the assignment settings page
      9. Set Completion tracking to 'Students can manually mark the activity as completed' the setting has a different value.
      10. Confirm there is a 'Set reminder in Timeline' setting in 'Activity completion' settings group.
      11. Click '?' icon next to 'Set reminder in Timeline' setting and confirm the text is 'This allows you to set a reminder for students to work on this activity. It will appear on the Timeline block in their Dashboard as "Database requires action"'

       

      Show
      As an admin create a course with Completion tracking > Enable completion tracking = Yes Create an Assignment. Expand "Activity completion" settings in the assignment settings page Set Completion tracking to 'Students can manually mark the activity as completed' the setting has a different value. Confirm there is a 'Set reminder in Timeline' setting in 'Activity completion' settings group. Click '?' icon next to 'Set reminder in Timeline' setting and confirm the text is 'This allows you to set a reminder for students to work on this activity. It will appear on the Timeline block in their Dashboard as "Assignment requires action"' Create an Database activity. Expand "Activity completion" settings in the assignment settings page Set Completion tracking to 'Students can manually mark the activity as completed' the setting has a different value. Confirm there is a 'Set reminder in Timeline' setting in 'Activity completion' settings group. Click '?' icon next to 'Set reminder in Timeline' setting and confirm the text is 'This allows you to set a reminder for students to work on this activity. It will appear on the Timeline block in their Dashboard as "Database requires action"'  
    • 1
    • HQ 2023 Planning I3 Moppies

      addHelpButton() function doesn't allow to pass variables to get_string so tooltip help strings can't use variables to better help the user.

      Discovered while working on MDL-78527, addHelpButton() doesn't accept variables, so we can't add to "Set reminder in Timeline" the correct string proposed by jverdaguer and the PX team.

      Once we have this improvement, the help tooltip for "Set reminder in Timeline" should be changed to "This allows you to set a reminder for students to work on this activity. It will appear on the Timeline block in their Dashboard as "[Activity type] requires action".

        1. (I) 10 Passed -- (Master)MDL-78746.png
          (I) 10 Passed -- (Master)MDL-78746.png
          70 kB
        2. (I) 11 Passed -- (Master)MDL-78746.png
          (I) 11 Passed -- (Master)MDL-78746.png
          77 kB
        3. (I) 5 Passed -- (Master)MDL-78746.png
          (I) 5 Passed -- (Master)MDL-78746.png
          67 kB
        4. (I) 6 Passed -- (Master)MDL-78746.png
          (I) 6 Passed -- (Master)MDL-78746.png
          78 kB

            amaia Amaia Anabitarte
            amaia Amaia Anabitarte
            Mikel Martín Corrales Mikel Martín Corrales
            Huong Nguyen Huong Nguyen
            Kim Jared Lucas Kim Jared Lucas
            Votes:
            1 Vote for this issue
            Watchers:
            7 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 5 hours, 9 minutes
                5h 9m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.