Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-78750

Matrix admin settings configured incorrectly

    XMLWordPrintable

Details

    • MOODLE_403_STABLE
    • MOODLE_403_STABLE
    • MDL-78750-master-int
    • Hide

      Mock setup from here

      Testing with no preset settings

      1. Setup a fresh install Moodle site
      2. Once the installation finished enable the Enable communication subsystem in Site admin > Development > Experimental settings
      3. Apply the patch and follow the upgrade process
      4. Verify that you see New settings - Matrix
      5. Skip the matrix settings by click Save changes
      6. Verify that you were not required to set the settings nor you see the settings anymore

      Testing when the selected communication provider is enabled and configured (continue from Testing with no preset settings)

      This part is to test when the plugin is enabled and configured

      1. Go to Site admin > Plugins > Communication > Matrix
      2. Fill in all the fields:
        Home server URL: http://localhost:8001/1
        Access token: test123
        Element web URL: http://localhost:8002
        And click the save changes button.
      3. Disable the selected plugin "Matrix" in Site admin > Plugins > Communication > Manage communication providers
      4. Go to Site admin > Courses > Add a new course to create a course
      5. Go to created course
      6. Click on "More" menu then click on "Communication"
      7. Verify that "Matrix" is not listed in "Provider" option
      8. Enable the selected plugin "Matrix" in Site admin > Plugins > Communication > Manage communication providers
      9. Go to created course
      10. Click on "More" menu then click on "Communication"
      11. Verify that "Matrix" is listed in "Provider" option
      12. Go to Site admin > Plugins > Communication > Matrix
      13. Empty all the fields and save changes
      14. Go to created course
      15. Click on "More" menu then click on "Communication"
      16. Verify that "Matrix" is not listed in "Provider" option
      Show
      Mock setup from here Testing with no preset settings Setup a fresh install Moodle site Once the installation finished enable the Enable communication subsystem in Site admin > Development > Experimental settings Apply the patch and follow the upgrade process Verify that you see New settings - Matrix Skip the matrix settings by click Save changes Verify that you were not required to set the settings nor you see the settings anymore Testing when the selected communication provider is enabled and configured (continue from Testing with no preset settings ) This part is to test when the plugin is enabled and configured Go to Site admin > Plugins > Communication > Matrix Fill in all the fields: Home server URL: http://localhost:8001/1 Access token: test123 Element web URL: http://localhost:8002 And click the save changes button. Disable the selected plugin "Matrix" in Site admin > Plugins > Communication > Manage communication providers Go to Site admin > Courses > Add a new course to create a course Go to created course Click on "More" menu then click on "Communication" Verify that "Matrix" is not listed in "Provider" option Enable the selected plugin "Matrix" in Site admin > Plugins > Communication > Manage communication providers Go to created course Click on "More" menu then click on "Communication" Verify that "Matrix" is listed in "Provider" option Go to Site admin > Plugins > Communication > Matrix Empty all the fields and save changes Go to created course Click on "More" menu then click on "Communication" Verify that "Matrix" is not listed in "Provider" option
    • 2
    • Team Hedgehog 2023 Sprint 3.2, Team Hedgehog 2023 Sprint 3.3

    Description

      The current way the matrix settings are configured causes multiple issues and limitations that we should be able to resolve reasonably easily:

      1. Generating a refresh token (which we currently have as  a required field) triggers a short expiry time for the access token (5 mins by default). We are also not using that token to refresh access, so it's essentially just making this impractical to use. We  should therefore just remove the refresh token setting altogether.
      2. For the remaining settings (home server URL and access token), those are currently required fields, which means if the communication subsystem is enabled, you are forced to input values even if you aren't ready to set up matrix (or don't intend to). We need to update those fields to be optional.
      3. After the changes in #2 are made, the existing system will assume if the plugin is enabled it is configured and ready to use, so matrix could be enabled on courses, which will cause errors when it attempts to set up a room/users. So the final step will be to make the necessary changes so where we check if the plugin is enabled/available for use, we also ensure that the matrix settings are not empty.
      4. Update any automated testing to reflect the changes (eg not filling in the refresh token now it doesn't exist), and add appropriate testing where needed (eg confirming expected behaviour where communication/matrix are enabled, but matrix settings are not configured).

      #3 is not a new concept in Moodle, for example some auth plugins such as LDAP can be "enabled" even though none of the settings to connect them to an external system and be functional are configured, they just won't be available on the login screen. So it may be worth having a quick look at how they handle that situation, if you need some ideas about how to approach it.

      Attachments

        Issue Links

          Activity

            People

              stevani.andolo@moodle.com Stevani Andolo
              dobedobedoh Andrew Lyons
              Meirza Meirza
              Andrew Lyons Andrew Lyons
              Kim Jared Lucas Kim Jared Lucas
              Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 week, 29 minutes
                  1w 29m

                  Clockify

                    Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.