Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.7, 1.9
    • Fix Version/s: 1.8.4, 1.9, 2.0
    • Component/s: Accessibility
    • Labels:
      None
    • Affected Branches:
      MOODLE_17_STABLE, MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_18_STABLE, MOODLE_19_STABLE, MOODLE_20_STABLE

      Description

      Clearly identify the distinction of each hypertext link with meaningful text if read out of context, or associate with alterative links that have the same explanatory characteristics, and provide mechanisms that allow repeated reading of sequences of links common to several pages to be avoided.

      WCAG 1.0 References: 13.1, 13.6
      Sec. 508 References: 1194.22 (o)

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              dougiamas Martin Dougiamas added a comment -

              Skip links have been added to the blocks, but one link to "skip to content" would be most useful.

              Show
              dougiamas Martin Dougiamas added a comment - Skip links have been added to the blocks, but one link to "skip to content" would be most useful.
              Hide
              dougiamas Martin Dougiamas added a comment -

              this can go in pagelib

              Show
              dougiamas Martin Dougiamas added a comment - this can go in pagelib
              Hide
              dougiamas Martin Dougiamas added a comment -

              Skip links have been added to course pages and admin settings pages (using accesshide to hide them from normal browsers)

              Show
              dougiamas Martin Dougiamas added a comment - Skip links have been added to course pages and admin settings pages (using accesshide to hide them from normal browsers)
              Hide
              nfreear Nick Freear added a comment - - edited

              We need more discussion of these accessibility fixes - this helps fix MDL-4994, however:
              1) Better if the 'pagelib' link was the first text on page, just after <body> opening tag.
              2) Its broken in Internet Explorer, see recent fix for skip block links, MDL-11676.
              3) Its inaccessible to most keyboard-only users (except screen reader users), MDL-11695.

              I'll try to quickly do a fix, for 1.9!

              Show
              nfreear Nick Freear added a comment - - edited We need more discussion of these accessibility fixes - this helps fix MDL-4994 , however: 1) Better if the 'pagelib' link was the first text on page, just after <body> opening tag. 2) Its broken in Internet Explorer, see recent fix for skip block links, MDL-11676 . 3) Its inaccessible to most keyboard-only users (except screen reader users), MDL-11695 . I'll try to quickly do a fix, for 1.9!
              Hide
              nfreear Nick Freear added a comment -

              This patch fixes the 3 issues identified above. It affects these 4 files,

              • all, course/format/(NAME)/format.php - 1 line.
              • lib/pagelib.php -2 lines, print_header
              • lib/weblib.php +5 lines, print_header, including regular expression (could be 'split')
              • theme/standard/styles_layout.css

              Also cleans up, lang/en_utf8/moodle.php, theme/standard/styles_color.css, theme/formal_white/fw_layout.css (unused styles).

              Show
              nfreear Nick Freear added a comment - This patch fixes the 3 issues identified above. It affects these 4 files, all, course/format/(NAME)/format.php - 1 line. lib/pagelib.php -2 lines, print_header lib/weblib.php +5 lines, print_header, including regular expression (could be 'split') theme/standard/styles_layout.css Also cleans up, lang/en_utf8/moodle.php, theme/standard/styles_color.css, theme/formal_white/fw_layout.css (unused styles).
              Hide
              nfreear Nick Freear added a comment -

              Martin, I'm happy to commit this, if you give the nod.

              Note, I'd like to revisit this post-1.9 as this only adds the skip link to course pages, not the home page, modules etc. (Which is why MDL-4994 hasn't been fixed!)

              Many thanks, Nick.

              Show
              nfreear Nick Freear added a comment - Martin, I'm happy to commit this, if you give the nod. Note, I'd like to revisit this post-1.9 as this only adds the skip link to course pages, not the home page, modules etc. (Which is why MDL-4994 hasn't been fixed!) Many thanks, Nick.
              Hide
              nfreear Nick Freear added a comment -

              I'm currently working on this (assigned to me, elevated priority). Having problems with CVS, but hope to commit tomorrow BST - HEAD and 1.9 branches.

              Show
              nfreear Nick Freear added a comment - I'm currently working on this (assigned to me, elevated priority). Having problems with CVS, but hope to commit tomorrow BST - HEAD and 1.9 branches.
              Hide
              nfreear Nick Freear added a comment -

              I've committed fixes in 2 stages to 1.9 branch and HEAD, tagged _MERGED.

              • Part 1 is based on the patch (..course-2.diff) above, but introduces the 'skip_main_destination' function to weblib.php - the skip link is still printed in pagelib.php and this fixes all course formats.
              • Part 2 is attached (..course-32.diff) - it replaces the pagelib skip link with one in print_header in weblib, and adds skip links to /index.php and course/index.php.

              Tested on,

              • 'weekscss' and 'topics' course formats;
              • 'standardwhite' and 'cornflower' themes;
              • Win/IE 6, Mac/Firefox 2, Safari (tab key not for links, not functional) (Opera, tab key not for links, use 'a' key).
              Show
              nfreear Nick Freear added a comment - I've committed fixes in 2 stages to 1.9 branch and HEAD, tagged _MERGED. Part 1 is based on the patch (..course-2.diff) above, but introduces the 'skip_main_destination' function to weblib.php - the skip link is still printed in pagelib.php and this fixes all course formats. Part 2 is attached (..course-32.diff) - it replaces the pagelib skip link with one in print_header in weblib, and adds skip links to /index.php and course/index.php. Tested on, 'weekscss' and 'topics' course formats; 'standardwhite' and 'cornflower' themes; Win/IE 6, Mac/Firefox 2, Safari (tab key not for links, not functional) (Opera, tab key not for links, use 'a' key).
              Hide
              nfreear Nick Freear added a comment -

              (Note, 'skip_main_destination' function should perhaps be 'print_skip_main_destination' - post 1.9?)

              Fixed.

              Show
              nfreear Nick Freear added a comment - (Note, 'skip_main_destination' function should perhaps be 'print_skip_main_destination' - post 1.9?) Fixed.
              Hide
              nfreear Nick Freear added a comment -

              Reopening - need to use "skip_main_destination" function in Ann Adamcik's "topicscss" course format, see MDL-9306.

              Show
              nfreear Nick Freear added a comment - Reopening - need to use "skip_main_destination" function in Ann Adamcik's "topicscss" course format, see MDL-9306 .
              Hide
              nfreear Nick Freear added a comment -

              (Link - Ann Adamcik's new "topicscss" course format.)

              Show
              nfreear Nick Freear added a comment - (Link - Ann Adamcik's new "topicscss" course format.)
              Hide
              nfreear Nick Freear added a comment -

              Fix to "topicscss" in HEAD.

              Show
              nfreear Nick Freear added a comment - Fix to "topicscss" in HEAD.
              Hide
              nfreear Nick Freear added a comment -

              (Non-specific link to MDL-9306, try again!)

              Show
              nfreear Nick Freear added a comment - (Non-specific link to MDL-9306 , try again!)
              Hide
              nfreear Nick Freear added a comment -

              (Adding link to meta-bug.)

              Show
              nfreear Nick Freear added a comment - (Adding link to meta-bug.)

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    11/Jan/08