Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-78858

Debugging notices in modal grade forms when editing gradebook

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Minor
    • 4.3
    • 4.3
    • Gradebook
    • MOODLE_403_STABLE
    • MOODLE_403_STABLE
    • Hide
      1. Log in as admin
      2. Navigate to Grades > Grade category settings in site administration
      3. Select the following Available aggregation types and save changes
        • Mean of grades (with extra credits)
        • Natural
      4. Create new course
      5. Navigate to course Grades
      6. Select Gradebook setup
      7. Press Add category
        • Category name: Top
        • Aggregation: Mean of grades (with extra credits)
        • Save
      8. Press Add category (again)
        • Category name: Second
        • Aggregation: Mean of grades (with extra credits)
        • Parent category: Top
        • Save
      9. Edit the Second category
        • Extra credit weight: 10.5
        • Save
      10. Confirm the Weight column of the table shows "10.5" for the Second category
      11. Press Add grade item
        • Item name: Something
        • Grade category: Second
        • Save
      12. Edit the Something item
        • Extra credit weight: 5.5
        • Save
      13. Confirm there are no debugging messages in your webserver error log, like:

        Debugging: Did you remember to call setType() for 'aggregationcoef'? Defaulting to PARAM_RAW cleaning.
        

      14. Confirm the Weight column of the table shows "5.5" for the Something item
      Show
      Log in as admin Navigate to Grades > Grade category settings in site administration Select the following Available aggregation types and save changes Mean of grades (with extra credits) Natural Create new course Navigate to course Grades Select Gradebook setup Press Add category Category name: Top Aggregation: Mean of grades (with extra credits) Save Press Add category (again) Category name: Second Aggregation: Mean of grades (with extra credits) Parent category: Top Save Edit the Second category Extra credit weight: 10.5 Save Confirm the Weight column of the table shows "10.5" for the Second category Press Add grade item Item name: Something Grade category: Second Save Edit the Something item Extra credit weight: 5.5 Save Confirm there are no debugging messages in your webserver error log, like: Debugging: Did you remember to call setType() for 'aggregationcoef'? Defaulting to PARAM_RAW cleaning. Confirm the Weight column of the table shows "5.5" for the Something item

    Description

      Found locally (and also seems stronk7 did in MDL-76407), the following debugging is triggered in error log when using the new grade item edit form from MDL-77637:

      [php:notice] [pid 34] [client 172.18.0.1:52782] Debugging: Did you remember to call setType() for 'aggregationcoef'? Defaulting to PARAM_RAW cleaning. in \n* line 1485 of /lib/formslib.php: call to debugging()\n* line 322 of /lib/formslib.php: call to moodleform->detectMissingSetType()\n* line 228 of /lib/formslib.php: call to moodleform->_process_submission()\n* line 73 of /lib/form/classes/dynamic_form.php: call to moodleform->__construct()\n* line 71 of /lib/form/classes/external/dynamic_form.php: call to core_form\\dynamic_form->__construct()\n* line ? of unknownfile: call to core_form\\external\\dynamic_form::execute()\n* line 251 of /lib/external/classes/external_api.php: call to call_user_func_array()\n* line 83 of /lib/ajax/service.php: call to core_external\\external_api::call_external_function()\n, referer: http://localhost:8000/grade/edit/tree/index.php?id=4
      

      Attachments

        Issue Links

          Activity

            People

              pholden Paul Holden
              pholden Paul Holden
              Mathew May Mathew May
              Mihail Geshoski Mihail Geshoski
              Kim Jared Lucas Kim Jared Lucas
              Votes:
              1 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 hour, 2 minutes
                  1h 2m

                  Clockify

                    Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.