Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-78903

Tiny media image plugin doesn't properly honour file upload options

XMLWordPrintable

    • MOODLE_401_STABLE, MOODLE_402_STABLE, MOODLE_403_STABLE
    • MOODLE_401_STABLE, MOODLE_402_STABLE, MOODLE_403_STABLE
    • MDL-78903-401
    • MDL-78903-403
    • MDL-78903-master
    • Hide
      1. Login as admin
      2. Create a course
      3. Create an assignment with Feedback comments enabled (just needed to show that pictures work on the assigned grading interface)
      4. Enrol user as a student
      5. Go to the grader report
      6. Click edit grade on a student
      7. Tick Overridden
      8. Click on the insert image icon in the feedback editor
      9. Verify the modal doesn't have the Browse Repositories button.
      10. Close the modal.
      11. Click on the Insert multimedia/media icon in the feedback editor.
      12. Verify the modal doesn't have the Browse repositories button, either on the link, video or audio. And also with the display options and subtitles and captions on the video and audio.
      13. Close the modal.
      14. Click on the H5P icon in the feedback editor.
      15. Verify the modal doesn't have the Browse Repositories button.
      Show
      Login as admin Create a course Create an assignment with Feedback comments enabled (just needed to show that pictures work on the assigned grading interface) Enrol user as a student Go to the grader report Click edit grade on a student Tick Overridden Click on the insert image icon in the feedback editor Verify the modal doesn't have the Browse Repositories button. Close the modal. Click on the Insert multimedia/media icon in the feedback editor. Verify the modal doesn't have the Browse repositories button, either on the link, video or audio. And also with the display options and subtitles and captions on the video and audio. Close the modal. Click on the H5P icon in the feedback editor. Verify the modal doesn't have the Browse Repositories button.
    • 1
    • Team Hedgehog 2023 Review 3, Team Hedgehog 2023 Sprint 4.1

      1. Create a course
      2. Create an assignment with Feedback comments enabled (just needed to show that pictures work on assign grading interface)
      3. Enrol some users
      4. Go to grader report
      5. Click on edit grade for some user
      6. Click on insert image icon in Feedback
      7. Browser repository button does nothing
      8. Click Cancel button on modal
      9. Drag and drop image into feedback field
      10. Observe error Failed to upload image: Cannot read properties of undefined (reading 'itemid')
      11. Go to assignment and upload image into feedback via assginment grading interface - that will work - image will be dispayed in feedback
      12. Go again on grader report and click edit grade for grade from step 11
      13. Broken image is displayed

      Expected: This Tiny image plugin should omit the "Browse repositories" button since the editor has been created with maxfiles=0 config (see the form code). This is honoured in Atto, using the same config.

        1. atto-url-in-field.png
          atto-url-in-field.png
          120 kB
        2. overridden.png
          overridden.png
          8 kB
        3. Screenshot 2023-11-02 at 4.02.30 pm.png
          Screenshot 2023-11-02 at 4.02.30 pm.png
          458 kB
        4. Screenshot 2023-11-02 at 4.02.50 pm.png
          Screenshot 2023-11-02 at 4.02.50 pm.png
          429 kB
        5. Screenshot 2023-11-02 at 4.02.57 pm.png
          Screenshot 2023-11-02 at 4.02.57 pm.png
          467 kB
        6. Screenshot 2023-11-02 at 4.03.00 pm.png
          Screenshot 2023-11-02 at 4.03.00 pm.png
          492 kB
        7. Screenshot 2023-11-02 at 4.03.10 pm.png
          Screenshot 2023-11-02 at 4.03.10 pm.png
          426 kB
        8. Screenshot from 2023-08-04 13-49-04.png
          Screenshot from 2023-08-04 13-49-04.png
          40 kB
        9. Screenshot from 2023-08-04 13-54-04.png
          Screenshot from 2023-08-04 13-54-04.png
          142 kB
        10. Screenshot from 2023-08-04 13-54-11.png
          Screenshot from 2023-08-04 13-54-11.png
          61 kB
        11. Screenshot from 2023-08-04 13-54-50.png
          Screenshot from 2023-08-04 13-54-50.png
          57 kB
        12. tiny-url-in-field-before-patch.png
          tiny-url-in-field-before-patch.png
          117 kB
        13. tiny-url-not-in-field.png
          tiny-url-not-in-field.png
          102 kB

            meirza.arson@moodle.com Meirza
            ilyatregubov Ilya Tregubov
            David Woloszyn David Woloszyn
            Huong Nguyen Huong Nguyen
            Mathew May Mathew May
            Votes:
            0 Vote for this issue
            Watchers:
            11 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 6 hours, 41 minutes
                6h 41m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.