Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-78922

Some elements are missing on grade category modal

    XMLWordPrintable

Details

    • MOODLE_403_STABLE
    • MOODLE_403_STABLE
    • MDL-78922-master
    • Hide
      1. Create a course
      2. Enable aggregations in site settings. Go to admin/settings.php?section=gradecategorysettings and enable all in Available aggregation types
      3. Create some scales
      4. Click edit category for course item
      5. Ensure you don't see Weights adjusted checkbox
      6. Go to gradebook setup page and click Add new category
      7. Change aggregation to Weighted mean of grades
      8. Ensure you can select grade type
      9. If gradetype is value ensure you see grademin and grademax. If not grademin and grademax should not be visibe
      10. IF gradetype is scale ensure you can select scale
      11. Save changes
      12. Add some grade items in category and add some grades to those. Override category total for some student
      13. Click edit category to open edit modal
      14. Ensure you see a warning 'This category has associated grade items which have been overridden. Therefore some grades have already been awarded, so the grade type cannot be changed. If you wish to change the maximum grade, you must first choose whether or not to rescale existing grades.'
      15. Ensure you can not change grade types
      16. Ensure you see 'Rescale overridden grades'
      17. Ensure you see warning 'You must choose whether to rescale existing grades or not.' when saving modal if 'Rescale overridden grades' is not set
      18. Set category aggregation to 'Weighted mean of grades'
      19. Create subcategory category2
      20. Open edit category modal for category2
      21. Ensure you don't see Weight adjusted checkbox
      Show
      Create a course Enable aggregations in site settings. Go to admin/settings.php?section=gradecategorysettings and enable all in Available aggregation types Create some scales Click edit category for course item Ensure you don't see Weights adjusted checkbox Go to gradebook setup page and click Add new category Change aggregation to Weighted mean of grades Ensure you can select grade type If gradetype is value ensure you see grademin and grademax. If not grademin and grademax should not be visibe IF gradetype is scale ensure you can select scale Save changes Add some grade items in category and add some grades to those. Override category total for some student Click edit category to open edit modal Ensure you see a warning 'This category has associated grade items which have been overridden. Therefore some grades have already been awarded, so the grade type cannot be changed. If you wish to change the maximum grade, you must first choose whether or not to rescale existing grades.' Ensure you can not change grade types Ensure you see 'Rescale overridden grades' Ensure you see warning 'You must choose whether to rescale existing grades or not.' when saving modal if 'Rescale overridden grades' is not set Set category aggregation to 'Weighted mean of grades' Create subcategory category2 Open edit category modal for category2 Ensure you don't see Weight adjusted checkbox
    • 1
    • Team Alpha - Planning I3-2023

    Description

      Some elements are missing from modal - grade type, scale, rescale grades

      Also some elements not supposed to be there:

      • Create a course
      • Go to gradebook setup
      • Create grade category category1
      • Create grade category category2 which has category1 as parent category
      • Set category1 aggegation to 'Simple weighted mean of grades'
      • On setup page note that category2 does not have weight override field available
      • Open edit category2 modal
      • There will be Weight adjusted checkbox which also enables weight field (Wrong)
      • Click on Show more
      • On advanced editing page as expected there won't be any weight adjusted checkbox

      Seems that check for parent category aggregation was missed

      Attachments

        Issue Links

          Activity

            People

              ilyatregubov Ilya Tregubov
              ilyatregubov Ilya Tregubov
              Mathew May Mathew May
              Jun Pataleta Jun Pataleta
              Ron Carl Alfon Yu Ron Carl Alfon Yu
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 6 hours, 34 minutes
                  6h 34m

                  Clockify

                    Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.