Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-78983

Follow-up for MDL-75047 (Revert flipping help icon direction in right-to-left languages)

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • 4.1.5, 4.2.2
    • 4.1.4, 4.2.1
    • Language
    • MOODLE_401_STABLE, MOODLE_402_STABLE
    • MOODLE_401_STABLE, MOODLE_402_STABLE
    • MDL-78983-401
    • MDL-78983-402
    • MDL-78983-master
    • Hide
      1. Log in as admin
      2. Go to Site admin > Language > Language packs
      3. Make sure your site language is initially in English.
      4. Install the Arabic (ar) and Hebrew (he) languages
        • Remember, you may need to run cron if you install them together
      5. Go to Site admin > Language > Language customisation
      6. Choose the Hebrew language pack and open it for editing.
      7. Search for "questioniconfollowlangdirection" in "langconfig.php"
      8. Set it to "no"
      9. Save changes to the language pack and confirm it.
      10. Edit your user profile
      11. Check the question mark icons on the form.
      12. Confirm that the question mark icons are displayed like "?".
      13. Open your user menu and change the language to Hebrew.
      14. Confirm that the question mark icons are displayed like "?".
      15. Change the language to Arabic
      16. Confirm that the question mark icons are now displayed like "؟"
      Show
      Log in as admin Go to Site admin > Language > Language packs Make sure your site language is initially in English. Install the Arabic (ar) and Hebrew (he) languages Remember, you may need to run cron if you install them together Go to Site admin > Language > Language customisation Choose the Hebrew language pack and open it for editing. Search for " questioniconfollowlangdirection " in " langconfig.php " Set it to " no " Save changes to the language pack and confirm it. Edit your user profile Check the question mark icons on the form. Confirm that the question mark icons are displayed like " ? ". Open your user menu and change the language to Hebrew. Confirm that the question mark icons are displayed like " ? ". Change the language to Arabic Confirm that the question mark icons are now displayed like " ؟ "

      MDL-75047 introduced the "thisicondirection" langconfig string to indicate whether question mark icons should be flipped.

      After some more discussions about it, several issues from the original patch were found:

      1. Debugging message right before the upgrade as the lang string does not exist yet in the cache until the upgrade.
        • This can be considered as trivial as debugging is only shown in developer mode and the warning should go away when the caches get purged.
      2. The lang string key "thisicondirection" is too generic when its intended purpose is specific to the question mark character.
      3. Lang string maintainer will need to know that they have to set the langconfig string's value specifically to "mirror". The logic of applying the extra class to flip the icon should be when the langconfig string does not match the standard one.
        • The logic of checking for a specific value for the langconfig string is less prone to accidents of misconfiguring the question icon direction.
      4. "standard" and "mirror" values for the langconfig string are not very descriptive. It's better to make it consistent with the other direction langconfig strings like "thisdirection" and set it to either "ltr" or "rtl".
      5. We are changing the default behaviour of showing the question mark for the RTL languages. Other languages such as Arabic, etc., where the question icon is being rendered properly will now be displayed incorrectly until the translation for the langconfig string comes through.

      Some options:

      Option A: Totally revert MDL-75047
      Option B: Fix the patch

            jpataleta Jun Pataleta
            jpataleta Jun Pataleta
            Shamim Rezaie Shamim Rezaie
            Huong Nguyen Huong Nguyen
            David Woloszyn David Woloszyn
            Votes:
            1 Vote for this issue
            Watchers:
            12 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour, 55 minutes
                1h 55m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.