-
Bug
-
Resolution: Fixed
-
Minor
-
4.1.4, 4.2.1
MDL-75047 introduced the "thisicondirection" langconfig string to indicate whether question mark icons should be flipped.
After some more discussions about it, several issues from the original patch were found:
Debugging message right before the upgrade as the lang string does not exist yet in the cache until the upgrade.- This can be considered as trivial as debugging is only shown in developer mode and the warning should go away when the caches get purged.
- The lang string key "thisicondirection" is too generic when its intended purpose is specific to the question mark character.
Lang string maintainer will need to know that they have to set the langconfig string's value specifically to "mirror". The logic of applying the extra class to flip the icon should be when the langconfig string does not match the standard one.- The logic of checking for a specific value for the langconfig string is less prone to accidents of misconfiguring the question icon direction.
- "standard" and "mirror" values for the langconfig string are not very descriptive. It's better to make it consistent with the other direction langconfig strings like "thisdirection" and set it to either "ltr" or "rtl".
- We are changing the default behaviour of showing the question mark for the RTL languages. Other languages such as Arabic, etc., where the question icon is being rendered properly will now be displayed incorrectly until the translation for the langconfig string comes through.
Some options:
Option A: Totally revert MDL-75047
Option B: Fix the patch
- Discovered while testing
-
MDL-75047 Revert flipping help icon direction in right-to-left languages
- Closed
- has been marked as being related by
-
MDL-79461 Langconfig.php should not contain translatable strings
- Open
-
MDLSITE-7371 Exclude langconfig.php strings from the translation stats calculation
- Resolved
- will be (partly) resolved by
-
MDL-79545 Use Unicode CLDR for language strings that are the same in all software projects
- Open