Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-79045

h2 heading generated by \print_grade_page_head should only cover the user name

XMLWordPrintable

    • MOODLE_401_STABLE, MOODLE_402_STABLE
    • MOODLE_401_STABLE, MOODLE_402_STABLE
    • MDL-79045-401
    • MDL-79045-master
    • Hide

      Note: Easier to test on Firefox

      Teacher
      1. Create a course with a few enrolled users and several graded activities (e.g. assignments, quizzes, etc.)
      2. Log in as a teacher in the course
      3. Go to the course > Grades > User report
      4. View the user report for a student.
      5. Inspect the accessibility properties of the user heading (The area with the user's picture, name, Message/Add to contact buttons)
      6. Confirm that the heading in the accessibility tree only contains the user's full name.
        • Note: Before the patch, the heading would be set as "User full name Message Add to contacts" in the accessibility tree.
      7. Go to Grades > Single view and select a user.
      8. Inspect the accessibility properties of the user heading (The area with the user's picture, name, Message/Add to contact buttons)
      9. Confirm that the heading in the accessibility tree only contains the user's full name.
      User viewing their grades
      1. Open a new incognito window or another browser session.
      2. Log in as a student and go to the Grades page in the course.
      3. Inspect the accessibility properties of the user heading (The area with the user's picture, name, Message/Add to contact buttons)
      4. Confirm that the "Message" and "Add to contact" buttons are not shown.
      5. Confirm that the heading in the accessibility tree only contains the user's full name.
      Show
      Note: Easier to test on Firefox Teacher Create a course with a few enrolled users and several graded activities (e.g. assignments, quizzes, etc.) Log in as a teacher in the course Go to the course > Grades > User report View the user report for a student. Inspect the accessibility properties of the user heading (The area with the user's picture, name, Message/Add to contact buttons) Confirm that the heading in the accessibility tree only contains the user's full name. Note: Before the patch, the heading would be set as "User full name Message Add to contacts" in the accessibility tree. Go to Grades > Single view and select a user. Inspect the accessibility properties of the user heading (The area with the user's picture, name, Message/Add to contact buttons) Confirm that the heading in the accessibility tree only contains the user's full name. User viewing their grades Open a new incognito window or another browser session. Log in as a student and go to the Grades page in the course. Inspect the accessibility properties of the user heading (The area with the user's picture, name, Message/Add to contact buttons) Confirm that the "Message" and "Add to contact" buttons are not shown. Confirm that the heading in the accessibility tree only contains the user's full name.

      From the accessibility audit report:

      The H2 tag for the student profile wraps multiple div elements, including the two icons for "message" and "add to contacts". As a result, these items are unnecessarily read as a heading by assistive technology

      This basically affects the grade report pages that use print_grade_page_head.

            jpataleta Jun Pataleta
            jpataleta Jun Pataleta
            Carlos Escobedo Carlos Escobedo
            Andrew Lyons Andrew Lyons
            Ron Carl Alfon Yu Ron Carl Alfon Yu
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 4 hours, 26 minutes
                4h 26m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.