Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-79052

Final deprecation of removing the legacy theme settings

    • Icon: Task Task
    • Resolution: Unresolved
    • Icon: Minor Minor
    • None
    • 4.3
    • Administration
    • MOODLE_403_STABLE
    • MDL-79052_final-deprecation-of-removing-the-legacy-theme-settings
    • Hide
      1. Run the following script:

        files=(
            "admin/presets/classes/local/setting/adminpresets_admin_setting_devicedetectregex.php"
            "admin/templates/setting_devicedetectregex.mustache"
        )
        for file in "${files[@]}"; do if [ -f "$file" ]; then echo "File exists: $file"; exit 1; fi done
        

      2. Verify the files are gone and the script outputs nothing
      3. Run the following commands:

        git grep -C2 -P '(?<!\w{1})get_device_type_list\('
        git grep -C2 'admin_setting_devicedetectregex'
        

      4. Verify it only returns the deprecated function stub and its mention in upgrade.txt or UPGRADING.MD
      5. Verify it returns nothing for the class name except its mention in upgrade.txt or UPGRADING.MD
      Show
      Run the following script: files=( "admin/presets/classes/local/setting/adminpresets_admin_setting_devicedetectregex.php" "admin/templates/setting_devicedetectregex.mustache" ) for file in "${files[@]}"; do if [ -f "$file" ]; then echo "File exists: $file"; exit 1; fi done Verify the files are gone and the script outputs nothing Run the following commands: git grep -C2 -P '(?<!\w{1})get_device_type_list\(' git grep -C2 'admin_setting_devicedetectregex' Verify it only returns the deprecated function stub and its mention in upgrade.txt or UPGRADING.MD Verify it returns nothing for the class name except its mention in upgrade.txt or UPGRADING.MD
    • Hide

      Code verified against automated checks.

      Checked MDL-79052 using repository: https://github.com/ziegenberg/moodle

      More information about this report

      Built on: Tue Apr 15 07:59:00 UTC 2025

      Show
      Code verified against automated checks. Checked MDL-79052 using repository: https://github.com/ziegenberg/moodle main (0 errors / 0 warnings) [branch: MDL-79052_final-deprecation-of-removing-the-legacy-theme-settings | CI Job ] More information about this report Built on: Tue Apr 15 07:59:00 UTC 2025

      The two settings that were removed:

      • enabledevicedetection
      • devicedetectregex

      The deprecation covers:

      1. Class adminpresets_admin_setting_devicedetectregex
      2. Class admin_setting_devicedetectregex
      3. Function core_useragent::get_device_type_list()
      4. Template file setting_devicedetectregex.mustache

       

            Daniel Ziegenberg Daniel Ziegenberg
            meirza.arson@moodle.com Meirza
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.