Loading...

XML

Word

Printable

Type: Improvement
Resolution: Fixed
Priority: Major
Fix Version/s: 4.3
Affects Version/s: 4.3
Component/s: Navigation, Themes
Labels:

Affected Branches:
MOODLE_403_STABLE
Fixed Branches:
MOODLE_403_STABLE
Epic Link:
Migrate callbacks to new hook system
Pull from Repository:
https://github.com/marinaglancy/moodle.git
Pull Main Branch:
~~MDL-79088~~-master
Pull Main Diff URL:
https://github.com/marinaglancy/moodle/compare/206c3a66e7...MDL-79088-master
Testing Instructions:
Hide

Install plugin https://github.com/marinaglancy/moodle-tool_sitenavdemo

As any user (or guest) observe that you can see "Custom item 1" in the site navigation and also "Custom menu" and it has a submenu

Make sure you can click on any custom item in this menu, the active node is highlighted correctly (with underline or check mark)
Show
Install plugin https://github.com/marinaglancy/moodle-tool_sitenavdemo As any user (or guest) observe that you can see "Custom item 1" in the site navigation and also "Custom menu" and it has a submenu Make sure you can click on any custom item in this menu, the active node is highlighted correctly (with underline or check mark)

Sprint:
WP Sprint 2023-I3.1 (Atlantic), WP Sprint 2023-I3.2 (Atlantic)

We already use a core hack in Workplace for it, why not make it official, I'm sure it will be useful for other plugins as well.

There are two parts here

1. Allow plugins (using hooks) to add items to the site primary navigation
2. Allow nested items in the site primary navigation - in fact the full functionality is already there and is used for custommenu, just a little bit is missing in the exporter

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

custom_menu.png
25 kB
25/Aug/23 12:58 AM
MDL-79088.png
630 kB
05/Sep/23 2:23 PM
navmenu.png
380 kB
30/Aug/23 2:21 PM
new_item.png
569 kB
30/Aug/23 2:26 PM

has been marked as being related by

MDL-80103 Add hook for secondary and tertiary navigation

Open

has to be done before

MDL-79336 add core\hook\stoppable_trait

Closed

is duplicated by

MDL-82291 Add a hook to enable plugins to add menu items to global nav the same as CFG->custommenuitems

Closed

Assignee:: Marina Glancy

Reporter:: Marina Glancy

Peer reviewer:: Paul Holden

Integrator:: Andrew Lyons

Tester:: Ron Carl Alfon Yu

Participants:: Adrian Greeve, Andrew Lyons, Brett Dalton, CiBoT, Jun Pataleta, Marina Glancy, Paul Holden, Petr Skoda, Ron Carl Alfon Yu

Votes:: 0 Vote for this issue

Watchers:: 16 Start watching this issue

Created:: 21/Aug/23 9:06 PM

Updated:: 26/Jun/24 12:28 PM

Resolved:: 05/Sep/23 11:07 PM

Estimated:

Not Specified

Remaining:

Logged:

4h 37m

Details

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify