Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Blocker
Fix Version/s: 4.4.6, 4.5.2
Affects Version/s: 3.9.23, 3.11.16, 4.2 regressions, 4.0.10, 4.1 regressions, 4.1.5, 4.2.2, 4.3, 4.4, 4.5
Component/s: Libraries
Labels:

Affected Branches:
MOODLE_311_STABLE, MOODLE_39_STABLE, MOODLE_400_STABLE, MOODLE_401_STABLE, MOODLE_402_STABLE, MOODLE_403_STABLE, MOODLE_404_STABLE, MOODLE_405_STABLE
Fixed Branches:
MOODLE_404_STABLE, MOODLE_405_STABLE
Pull from Repository:
https://github.com/DSI-Universite-Rennes2/moodle/
Pull 4.4 Branch:
79121-normalize-proxy-bypass-404
Pull 4.4 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_404_STABLE...DSI-Universite-Rennes2:moodle:79121-normalize-proxy-bypass-404
Pull 4.5 Branch:
79121-normalize-proxy-bypass-405
Pull 4.5 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_405_STABLE...DSI-Universite-Rennes2:moodle:79121-normalize-proxy-bypass-405
Pull Main Branch:
79121-normalize-proxy-bypass-main
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...DSI-Universite-Rennes2:moodle:79121-normalize-proxy-bypass-main
Workaround:

Hide

In your config.php, you can define $CFG->proxybypass that explicitly declares each subdomain you want to bypass (without extra spaces around commas).

Or simply, replace .domain.tld to *.domain.tld (always without extra spaces around commas).

Show
In your config.php, you can define $CFG->proxybypass that explicitly declares each subdomain you want to bypass (without extra spaces around commas). Or simply, replace .domain.tld to *.domain.tld (always without extra spaces around commas).
Testing Instructions:
Hide

Setup:

Ensure you have not defined $CFG->proxybypass in your config.php.

Test:

Log in as admin on your site

Go to site administration > server > HTTP

Set in "Proxy bypass hosts" field this value : 192.168., .mydomain.com

Confirm that the value has been replaced by : 192.168.0.0/16,*.mydomain.com
Show
Setup: Ensure you have not defined $CFG->proxybypass in your config.php. Test: Log in as admin on your site Go to site administration > server > HTTP Set in "Proxy bypass hosts" field this value : 192.168., .mydomain.com Confirm that the value has been replaced by : 192.168.0.0/16,*.mydomain.com
Pre-check results:
Hide

Code verified against automated checks.

Checked ~~MDL-79121~~ using repository: https://github.com/DSI-Universite-Rennes2/moodle/

MOODLE_404_STABLE (0 errors / 0 warnings) [branch: 79121-normalize-proxy-bypass-404 | CI Job]

MOODLE_405_STABLE (0 errors / 0 warnings) [branch: 79121-normalize-proxy-bypass-405 | CI Job]

main (0 errors / 0 warnings) [branch: 79121-normalize-proxy-bypass-main | CI Job]

_{More information about this report}

Built on: Tue Dec 17 03:09:02 PM UTC 2024
Show
Code verified against automated checks. Checked MDL-79121 using repository: https://github.com/DSI-Universite-Rennes2/moodle/ MOODLE_404_STABLE (0 errors / 0 warnings) [branch: 79121-normalize-proxy-bypass-404 | CI Job ] MOODLE_405_STABLE (0 errors / 0 warnings) [branch: 79121-normalize-proxy-bypass-405 | CI Job ] main (0 errors / 0 warnings) [branch: 79121-normalize-proxy-bypass-main | CI Job ] More information about this report Built on: Tue Dec 17 03:09:02 PM UTC 2024
Automated test results:
Hide

Launching automatic jobs for branch 79121-proxy-bypass-404

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17267/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58837/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58838/ Behat (Firefox - boost)

Launching automatic jobs for branch 79121-proxy-bypass-405

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17268/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58839/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58840/ Behat (Firefox - boost)

Launching automatic jobs for branch 79121-proxy-bypass-main

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17269/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58841/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58842/ Behat (Firefox - boost)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58843/ Behat (Firefox - classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58844/ App tests (stable app version) --> unrelated

Built on: Wed Nov 6 08:25:24 PM UTC 2024
Show
Launching automatic jobs for branch 79121-proxy-bypass-404 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17267/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58837/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58838/ Behat (Firefox - boost) Launching automatic jobs for branch 79121-proxy-bypass-405 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17268/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58839/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58840/ Behat (Firefox - boost) Launching automatic jobs for branch 79121-proxy-bypass-main https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17269/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58841/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58842/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58843/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58844/ App tests (stable app version) --> unrelated Built on: Wed Nov 6 08:25:24 PM UTC 2024

The description of proxybypass variable is :
> Comma separated list of (partial) hostnames or IPs that should bypass proxy (e.g., 192.168., .mydomain.com)

However it seems no longer possible to use the .mydomain.com format.

Previously if the queried domain was mydomain.com or anysubdomain.mydomain.com, the proxy settings were not used.

Since MDL-74289 changes, Moodle tries to use your proxy settings.

In our case, it breaks access to our internal authentication system that should not use our http proxy.

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

MDL-79121.png
416 kB
18/Dec/24 1:29 PM

has been marked as being related by

MDL-79233 PR only: MDL-79121 - proxy bypass no longer handles partial hostnames

Closed

MDL-79964 PR only: MDL-79121 - PR 2 - proxy bypass no longer handles partial hostnames

Closed

MDL-83581 PR only: MDL-79121 - prevent admins to define an invalid proxybypass value

Closed

has to be done before

MDL-79963 Improve proxybypass field in admin

Open

is duplicated by

MDL-79171 Regression caused by MDL-74289 fix

Closed

MDL-79335 proxy bypass does not trim whitespace

Closed

will help resolve

MDL-58517 ip_utils::is_domain_in_allowed_list does not trim

Closed

(1 is duplicated by, 1 will help resolve)

Assignee:: Julien Boulen

Reporter:: Julien Boulen

Peer reviewer:: Raquel Ortega

Integrator:: Jun Pataleta

Tester:: Ron Carl Alfon Yu

Participants:: CiBoT, Julia Verdaguer, Julien Boulen, Jun Pataleta, Melanie Treitinger, Nick Phillips, Raquel Ortega, Ron Carl Alfon Yu

Votes:: 15 Vote for this issue

Watchers:: 21 Start watching this issue

Created:: 23/Aug/23 3:19 AM

Updated:: 04/Feb/25 1:51 PM

Resolved:: 19/Dec/24 8:28 PM

Estimated:

Remaining:

Logged:

3d 39m

Details

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify