Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Minor
Fix Version/s: 4.1.6, 4.2.3
Affects Version/s: 4.1.5
Component/s: Administration
Labels:
- CatalystIT
- ci
- partner
- triaged

Affected Branches:
MOODLE_401_STABLE
Fixed Branches:
MOODLE_401_STABLE, MOODLE_402_STABLE
Pull from Repository:
https://github.com/Peterburnett/moodle
Pull 4.1 Branch:
~~MDL-79169~~-int-deprecate-401
Pull 4.1 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_401_STABLE...Peterburnett:moodle:MDL-79169-int-deprecate-401
Pull Main Branch:
~~MDL-79169~~-int-deprecate-m
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/master...Peterburnett:moodle:MDL-79169-int-deprecate-m
Testing Instructions:
Hide

Prerequisite:

PHP 8.1 or higher

Debugging set to Developer

Enable debugdisplay

1) Get a unix timestamp for 1 hour in the future from https://www.unixtimestamp.com/

2) Run `php admin/cli/cfg.php --name=maintenance_later --set=<TIMESTAMP>` with the timestamp for step 1

3) Load the frontpage of the moodle installation.

4) Confirm there is no deprecation message on the frontpage for float to int cast losing precision.
Show
Prerequisite: PHP 8.1 or higher Debugging set to Developer Enable debugdisplay 1) Get a unix timestamp for 1 hour in the future from https://www.unixtimestamp.com/ 2) Run `php admin/cli/cfg.php --name=maintenance_later --set=<TIMESTAMP>` with the timestamp for step 1 3) Load the frontpage of the moodle installation. 4) Confirm there is no deprecation message on the frontpage for float to int cast losing precision.

Using the maintenance_warning() function on PHP 8.1 results in a deprecation notice being emitted for an int to float cast. The float value should be floored before the modulo operation which does the implicit cast.

To replicate:
- Debugging on

php /admin/cli/cfg.php --name=maintenance_later --set=<TIME + 300>

Visit gui and observe deprecation warning in DOM.

Deprecated: Implicit conversion from float 1305.1166666666666 to int loses precision in /var/www/moodlecore/lib/outputrenderers.php on line 844

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

(I) Passed -- (Master)MDL-79169.png
128 kB
29/Aug/23 1:30 PM

is child of

MDL-76356 Implicit conversion to ints/arrays shows notice in PHP 8.1

Closed

Assignee:: Peter Burnett

Reporter:: Peter Burnett

Peer reviewer:: Matthew Hilton

Integrator:: Andrew Lyons

Tester:: Kim Jared Lucas

Participants:: Andrew Lyons, CiBoT, Dmitrii Metelkin, Kim Jared Lucas, Matthew Hilton, Peter Burnett

Votes:: 0 Vote for this issue

Watchers:: 5 Start watching this issue

Created:: 25/Aug/23 8:04 AM

Updated:: 02/Sep/23 10:33 AM

Resolved:: 02/Sep/23 10:33 AM

Estimated:

Remaining:

Logged:

31m

Details

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify