Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-79241

Plugins of type 'factor' are defined incorrectly in core

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Minor
    • 4.3
    • 4.2.2, 4.3
    • Authentication
    • MOODLE_402_STABLE, MOODLE_403_STABLE
    • MOODLE_403_STABLE
    • MDL-79241-master
    • Hide
      1. Go to site administration>plugins>plugins overview
      2. Make sure the 'Factor types' section has a management link in the header, all plugins have "Uninstall" link
      3. Install plugin https://github.com/marinaglancy/moodle-factor_dummy
      4. Enable this "Dummy" factor in Site administration>Plugins>Admin tools>Multi-factor authentication>Manage MFA
      5. Enable another factor plugin type
      6. Change the order of enabled factors
      7. Uninstall this plugin, make sure it uninstalls without problems and warnings
      Show
      Go to site administration>plugins>plugins overview Make sure the 'Factor types' section has a management link in the header, all plugins have "Uninstall" link Install plugin https://github.com/marinaglancy/moodle-factor_dummy Enable this "Dummy" factor in Site administration>Plugins>Admin tools>Multi-factor authentication>Manage MFA Enable another factor plugin type Change the order of enabled factors Uninstall this plugin, make sure it uninstalls without problems and warnings

    Description

      This is how plugins of type 'factor' are displayed on the "Plugins overview" page:

      There are multiple problems with them:

      • language string for plugin type is missing (fixed in MDL-78946)
      • all standard factor plugins are not marked as standard (fixed in MDL-79238)
      • all 'factor' plugins for some reason define dependency on their parent plugin (obviously they can't be installed if the parent is not installed)
      • it is impossible to uninstall plugins of this type
      • the management link is missing from the plugins overview page
      • all version.php files mention 4.2 but this functionality is only available from 4.3 (in fact, I removed this completely)
      • no other existing standard plugin defines a 'release', mostly because the versions are bumped automatically by the script but nobody will bother updating releases and they will go out of sync very soon
      • one of the standard plugins had MATURITY_ALPHA

      Attachments

        Issue Links

          Activity

            People

              marina Marina Glancy
              marina Marina Glancy
              Paul Holden Paul Holden
              Andrew Lyons Andrew Lyons
              Kim Jared Lucas Kim Jared Lucas
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 4 hours, 12 minutes
                  4h 12m

                  Clockify

                    Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.